-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken API usage of latest WSL "No cache object found" #3797
Comments
I added this "enabledApiProposals": [
"extensionRuntime",
"extensionsAny"
] to
and ran CTRL + SHIFT + P -> Reset CMake Tools Extension ... And it works! |
@mortenfc Does this also happen in the official release version? It'd be great if you could find what version this started happening on to help us investigate. Thanks! |
Also, we have never supported |
My guess is that this is a change in the WSL extension, and either it's a bug with that extension, or a breaking change that we need to adapt to in our extension, but it requires more investigation. I currently do not think that it is a regression in the most recent release |
To be clear, the outcome was the same for last few releases of cmake-tools |
After I installed the extension WSL, vscode prompted me to install Ubuntu on a windows machine, can you provide a more detailed step-by-step so that we can reproduce the issue. |
Just install wsl with ubuntu 22.04 on windows 11, there are guides online. Open wsl through extension in vscode on windows, have some cmake project with a preset. Use wsl ext v0.88.2. Configure the preset with cmd line then try to configure with the cmake-tools extension. Then check vscode output tab -> select Extension Host (Remote) |
@chrmarti @lramos15 @eleanorjboyd Pinging you all because you have recently contributed to the WSL extension. We believe this issue should be transferred to the WSL extension. Thanks! |
@gcampbell-msft This looks like you might be calling I suggest to check where this happens and avoid stringifying the extension context. |
@chrmarti For my knowledge going forward, were you able to reproduce this yourself and this is where your call stack is from? I mainly ask so that if I implement a test fix, is it possible for me to send it your way to test? Thanks for your help and for the information. |
We have a ton of cmake targets (and thus .jsons created from the preset?) so this might be an issue isolated to very big projects, I don't know. ⋊> ~/r/m/b/g/.c/a/v/reply on change-VIK-7689 ↑ pwd 14:16:26
/home/mfjordchris/repos/microsar-adaptive/build/gcc7_linux_x86_64/.cmake/api/v1/reply
⋊> ~/r/m/b/g/.c/a/v/reply on change-VIK-7689 ↑ count ./* 14:16:30
2209
⋊> ~/r/m/b/g/.c/a/v/reply on change-VIK-7689 ↑ du -h ../reply 14:16:31
34M ../reply |
@gcampbell-msft This is the stack from the original report at the top of this issue by @mortenfc. |
@mortenfc @chrmarti @mfjordchris Could you all provide a sample project that this reproduces with? I tried to reproduce this with the WSL extension, and it doesn't seem to reproduce. Thanks |
@chrmarti Do you think that the change in this PR: #3880 would resolve this issue? @mortenfc Could you try this zip (change to .vsix before installing) and see if it fixes it? |
@gcampbell-msft Yes, from what I see! |
It's a big internal repo with a crap ton of jsons created from the presets. I wouldn't know how to reproduce with an open source. I'll try the new version and see if I get the problem again :) |
before the change (latest release):
After the change (latest pre-release):
|
@gcampbell-msft So the new release fixed something most likely! |
@mortenfc We have attempted to verify this issue on CMake tools: v1.19.45, but we don't have detailed reproduction steps to reproduce it. Are you able to go and verify that the issue is fixed? |
I just installed 1.19.49 from marketplace and ran configure and it succeeded. Maybe there is a Cache Object now, and before it would try to stringify when that uncaught error happened. |
Brief Issue Summary
Fails to configure. Gets stuck loading .jsons from the .cmake folder.
WSL remote extension host shows the reason:
cmake build output:
And then nothing
CMake Tools Diagnostics
Debug Log
Additional Information
This used to work, I guess one party broke backwards compatibility with the other.
WSL:
The text was updated successfully, but these errors were encountered: