Added local Mongo connection debugging tips #1184
Conversation
StephenWeatherford
force-pushed
the
saw/mongo-emulator
branch
from
209e5f9
to
70cfe5f
Compare
|
|
||
| // Example error: "failed to connect to server [localhost:10255] on first connect [MongoError: connect ECONNREFUSED 127.0.0.1:10255]" | ||
| // Example error: "failed to connect to server [127.0.0.1:27017] on first connect [MongoError: connect ECONNREFUSED 127.0.0.1:27017]" | ||
| if (name === 'MongoError' && /ECONNREFUSED/.test(message) && /(localhost|127\.0\.0\.1)/.test(message)) { |
There was a problem hiding this comment.
Would prefer to use parseError
There was a problem hiding this comment.
I can't because that brings in vscode from the ui lib which doesn't work in the context of the language server, which uses this... :-) (Originally did it that way.)
| @@ -75,7 +75,7 @@ export class MongoAccountTreeItem extends AzureParentTreeItem<IMongoTreeRoot> { | |||
| } catch (error) { | |||
| let message = parseError(error).message; | |||
| if (this._root.isEmulator && message.includes("ECONNREFUSED")) { | |||
| error.message = "Unable to reach emulator. Please ensure it is started and connected to the port specified by the 'cosmosDB.emulator.mongoPort' setting, then try again.\n" + message; | |||
| error.message = `Unable to reach emulator. See ${Links.LocalConnectionDebuggingTips} for debugging tips.\n${message}`; | |||
There was a problem hiding this comment.
Can we use throw new Error( for this? I suppose this option is better because it maintains the original stack and error type, but it's definitely less robust
There was a problem hiding this comment.
As this is a hot bug fix, I only want to change what's absolutely necessary. (Actually this is a question I've waffled on, though - arguments on both sides.)
There was a problem hiding this comment.
Can we combine this logic into one function? You've got two catch blocks each with slightly different error handling, but I think they're meant to do the exact same thing
I wanted to do that, that's why I was asking the question in e-mail. In the end, this caused too many changes (have to pass around isEmulator in lots of places, and it's got that weird code path where it's not set when I need it). I decided it was too risky to do right before releasing.
Fixes #1137
Fixes #1000
Related to #706?