Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive Regions coloring #1907

Closed
Kronuz opened this issue May 1, 2018 · 4 comments
Closed

Inactive Regions coloring #1907

Kronuz opened this issue May 1, 2018 · 4 comments
Assignees
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@Kronuz
Copy link

Kronuz commented May 1, 2018

VSCode Version 1.22.2
C/C++ extension Version 0.16.1

dimInactiveRegions option should use the same coloring as comments in the active theme, when using editor.renderWhitespace that also should maintain theme coloring.

Inactive regions look awkward otherwise:

coloring

@sean-mcmanus
Copy link
Collaborator

I think we're going to use opacity to dim the text: microsoft/vscode#43004 .

@Kronuz
Copy link
Author

Kronuz commented May 1, 2018

That sounds reasonable... but if you use opacity as it is now, whitespaces will look differently from indentation guides. In the example above both indentation guides and whitespaces have a custom color (same color both), however indentation guides are currently keeping the color as they should, but not whitespaces.

@bobbrow
Copy link
Member

bobbrow commented May 1, 2018

When we switch to opacity we won't change the original color anymore. But in that case I think the opacity would still affect those characters. I think the case could be made that VS Code shouldn't apply decorations to whitespace characters since they are not technically part of the file contents. I wonder if it's just something they overlooked. It would be a real nuisance if we had to break up all of our text decorations into words.

@sean-mcmanus sean-mcmanus added this to the 0.17.4 milestone May 23, 2018
@sean-mcmanus sean-mcmanus modified the milestones: 0.17.4, 0.17.5 May 31, 2018
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 7, 2018
@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jun 8, 2018

This is fixed with 0.17.5-insiders at https://github.com/Microsoft/vscode-cpptools/releases/tag/v0.17.5-insiders .

UPDATE: Fixed in 0.17.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

4 participants