Update HTTP Proxy to fix telemetry #9828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Sep 1, 2022
|
Actually, I don't think we use those download functions anymore. Can we just remove https-proxy-agent and the now unused functions that call it? |
Shall we abandon this PR, and go with this one instead? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the lack of telemetry caused by the new key.
After a deep dive into the C++ extension code it appears that the older versions of
https-proxy-agentwould rewrite thehttpsmodule in a way that was non standard to what the node docs would have. Therefore the use of the https module within@vscode/extension-telemetrywas throwing an error when it was in fact syntactically correct. This updates the module and I now see data flowing correctly via the new key into the extension data tables. I still recommend testing all other use cases of thehttps-proxy-agent.Ref: microsoft/vscode#93167 (comment)
TS Config Update Ref: TooTallNate/node-agent-base#56
cc @Colengms @bobbrow