Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview is disposed #2820

Closed
afaddoul opened this issue Mar 29, 2021 · 7 comments
Closed

Webview is disposed #2820

afaddoul opened this issue Mar 29, 2021 · 7 comments
Labels
Milestone

Comments

@afaddoul
Copy link

Does this occur consistently?
Repro steps:

Action: vscode-docker.help.openStartPage
Error type: Error
Error Message: Webview is disposed

Version: 1.11.0
OS: darwin
OS Release: 20.3.0
Product: Visual Studio Code
Product Version: 1.54.3
Language: en

Call Stack
_.assertNotDisposed extensionHostProcess.js:88:53320
_.set html [as html] extensionHostProcess.js:88:52689
StartPage.createOrShow extension.bundle.js:1053:146275
openStartPage extension.bundle.js:65:393543
@bwateratmsft
Copy link
Contributor

@afaddoul does this happen consistently?

@afaddoul
Copy link
Author

no, actually it was the first time

@PavelSosin-320
Copy link

PavelSosin-320 commented Mar 31, 2021

WebView? Is it one of 2 pieces of code (WebView, Chrome) that were urgently updated by Google and caused a total Internet blackout for 7 hours until people upgraded them in my country?

@bwateratmsft
Copy link
Contributor

@PavelSosin-320 this would be the webview for our start page. I don't think this issue is at all related to the Chrome update.

@bwateratmsft
Copy link
Contributor

We're planning to revise the start page to use the new model being demonstrated in Insiders right now.

@bwateratmsft bwateratmsft added this to the Future milestone Mar 31, 2021
@bwateratmsft bwateratmsft mentioned this issue Apr 16, 2021
@karolz-ms karolz-ms modified the milestones: Future, 1.13.0 Apr 29, 2021
@karolz-ms
Copy link
Contributor

Pulling from Future to 1.13 since several people have reported it recently, see related issues, @dbreshears FYI

This was referenced May 8, 2021
@dbreshears dbreshears modified the milestones: 1.13.0, 1.14.0 May 12, 2021
This was referenced May 14, 2021
@karolz-ms karolz-ms self-assigned this May 20, 2021
karolz-ms added a commit that referenced this issue May 21, 2021
* Fix "webview is disposed" error

Fixes issue #2820

The poblem is likely due to a handful of async calls done beteween when the start page view is created and when its content is set. That gives the user an opportunity to close the start page before we attempt to set its content. It is especially tempting since during the time the content is computed the already-visible start page panel is empty.

This change front-loads that async processing so that the webview creation becomes fully synchronous.
@karolz-ms karolz-ms removed their assignment May 21, 2021
@karolz-ms karolz-ms mentioned this issue May 24, 2021
ravipal added a commit that referenced this issue May 24, 2021
* Add malware scan (#2942)

* Add malware scan.

* Actually add malware scan.

* Move malware task and stop immediately.

* Update UI dependency for new icon. (#2955)

* Update vsce dependency (#2957)

* Fix "webview is disposed" error (#2959)

* Fix "webview is disposed" error

Fixes issue #2820

The poblem is likely due to a handful of async calls done beteween when the start page view is created and when its content is set. That gives the user an opportunity to close the start page before we attempt to set its content. It is especially tempting since during the time the content is computed the already-visible start page panel is empty.

This change front-loads that async processing so that the webview creation becomes fully synchronous.

* Add missing description for debug config property. (#2963)

Co-authored-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>
ravipal added a commit that referenced this issue May 25, 2021
* Prepare for release (#2929)

* Upgrade the vsce to 1.88 to get latest underscore (#2930)

* Add extendedLocation property in Plan and Site creation (#2931)

* Add extendedLocation property in Plan and Site creation

* Updating comment

* Ravipal/merge from main (#2964)

* Add malware scan (#2942)

* Add malware scan.

* Actually add malware scan.

* Move malware task and stop immediately.

* Update UI dependency for new icon. (#2955)

* Update vsce dependency (#2957)

* Fix "webview is disposed" error (#2959)

* Fix "webview is disposed" error

Fixes issue #2820

The poblem is likely due to a handful of async calls done beteween when the start page view is created and when its content is set. That gives the user an opportunity to close the start page before we attempt to set its content. It is especially tempting since during the time the content is computed the already-visible start page panel is empty.

This change front-loads that async processing so that the webview creation becomes fully synchronous.

* Add missing description for debug config property. (#2963)

Co-authored-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>

* Update change log to includ LIMA support (#2965)

* Update date on release notes (#2966)

Co-authored-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>
@karolz-ms
Copy link
Contributor

This was actually fixed in 0.13 release

@dbreshears dbreshears modified the milestones: 1.14.0, 1.13.0 Jun 9, 2021
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants