Add extendedLocation property in Plan and Site creation #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolz-ms
requested changes
May 13, 2021
karolz-ms
approved these changes
May 13, 2021
ravipal
added a commit
that referenced
this pull request
May 25, 2021
* Prepare for release (#2929) * Upgrade the vsce to 1.88 to get latest underscore (#2930) * Add extendedLocation property in Plan and Site creation (#2931) * Add extendedLocation property in Plan and Site creation * Updating comment * Ravipal/merge from main (#2964) * Add malware scan (#2942) * Add malware scan. * Actually add malware scan. * Move malware task and stop immediately. * Update UI dependency for new icon. (#2955) * Update vsce dependency (#2957) * Fix "webview is disposed" error (#2959) * Fix "webview is disposed" error Fixes issue #2820 The poblem is likely due to a handful of async calls done beteween when the start page view is created and when its content is set. That gives the user an opportunity to close the start page before we attempt to set its content. It is especially tempting since during the time the content is computed the already-visible start page panel is empty. This change front-loads that async processing so that the webview creation becomes fully synchronous. * Add missing description for debug config property. (#2963) Co-authored-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com> * Update change log to includ LIMA support (#2965) * Update date on release notes (#2966) Co-authored-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an App Service Plan or App Service is created in custom location we need to pass the following property.
"extendedLocation": {
"name": ,
"type": "customLocation"
},
vscode-azureappservice@0.82.0 sets this property in plan creation and added this property to site creation.