Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rel/1.13.0 to main #2970

Merged
merged 7 commits into from
May 25, 2021
Merged

Merge rel/1.13.0 to main #2970

merged 7 commits into from
May 25, 2021

Conversation

ravipal
Copy link
Contributor

@ravipal ravipal commented May 25, 2021

Merge rel/1.13.0 to main

ravipal and others added 7 commits May 12, 2021 17:23
* Add extendedLocation property in Plan and Site creation

* Updating comment
* Add malware scan (#2942)

* Add malware scan.

* Actually add malware scan.

* Move malware task and stop immediately.

* Update UI dependency for new icon. (#2955)

* Update vsce dependency (#2957)

* Fix "webview is disposed" error (#2959)

* Fix "webview is disposed" error

Fixes issue #2820

The poblem is likely due to a handful of async calls done beteween when the start page view is created and when its content is set. That gives the user an opportunity to close the start page before we attempt to set its content. It is especially tempting since during the time the content is computed the already-visible start page panel is empty.

This change front-loads that async processing so that the webview creation becomes fully synchronous.

* Add missing description for debug config property. (#2963)

Co-authored-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>
@ravipal ravipal requested a review from a team as a code owner May 25, 2021 18:52
@@ -1,6 +1,6 @@
{
"name": "vscode-docker",
"version": "1.12.5-alpha",
"version": "1.13.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, this need to be updated to 1.14.0-alpha, but that can happen as a separate PR

@ravipal ravipal merged commit 5b147c5 into main May 25, 2021
@ravipal ravipal deleted the ravipal/mergefrom1.13 branch May 25, 2021 19:11
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants