Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add malware scan #2942

Merged
merged 3 commits into from
May 14, 2021
Merged

Add malware scan #2942

merged 3 commits into from
May 14, 2021

Conversation

philliphoff
Copy link
Contributor

Adds malware scanning as part of our CI process, per compliance requirements.

@philliphoff philliphoff requested a review from a team as a code owner May 14, 2021 21:38
@philliphoff philliphoff merged commit 5fbb515 into main May 14, 2021
@philliphoff philliphoff deleted the philliphoff-malware-scan branch May 14, 2021 22:29
ravipal added a commit that referenced this pull request May 24, 2021
* Add malware scan (#2942)

* Add malware scan.

* Actually add malware scan.

* Move malware task and stop immediately.

* Update UI dependency for new icon. (#2955)

* Update vsce dependency (#2957)

* Fix "webview is disposed" error (#2959)

* Fix "webview is disposed" error

Fixes issue #2820

The poblem is likely due to a handful of async calls done beteween when the start page view is created and when its content is set. That gives the user an opportunity to close the start page before we attempt to set its content. It is especially tempting since during the time the content is computed the already-visible start page panel is empty.

This change front-loads that async processing so that the webview creation becomes fully synchronous.

* Add missing description for debug config property. (#2963)

Co-authored-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>
ravipal added a commit that referenced this pull request May 25, 2021
* Prepare for release (#2929)

* Upgrade the vsce to 1.88 to get latest underscore (#2930)

* Add extendedLocation property in Plan and Site creation (#2931)

* Add extendedLocation property in Plan and Site creation

* Updating comment

* Ravipal/merge from main (#2964)

* Add malware scan (#2942)

* Add malware scan.

* Actually add malware scan.

* Move malware task and stop immediately.

* Update UI dependency for new icon. (#2955)

* Update vsce dependency (#2957)

* Fix "webview is disposed" error (#2959)

* Fix "webview is disposed" error

Fixes issue #2820

The poblem is likely due to a handful of async calls done beteween when the start page view is created and when its content is set. That gives the user an opportunity to close the start page before we attempt to set its content. It is especially tempting since during the time the content is computed the already-visible start page panel is empty.

This change front-loads that async processing so that the webview creation becomes fully synchronous.

* Add missing description for debug config property. (#2963)

Co-authored-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>

* Update change log to includ LIMA support (#2965)

* Update date on release notes (#2966)

Co-authored-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com>
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants