Add back onLanguage:dockerfile activation event
#3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
approved these changes
May 4, 2023
alexyaang
pushed a commit
that referenced
this pull request
May 9, 2023
alexyaang
added a commit
that referenced
this pull request
May 11, 2023
* scaffold tasks with native architecture * specified return architecture Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * moved util file to appropriate location * moved more util functions to appropriate folder * added stricter type cheking * refactored switch statements * refactored more switch statements * removed l10n * slightly changes json schema * Bump yaml from 2.2.1 to 2.2.2 (#3916) Bumps [yaml](https://github.com/eemeli/yaml) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add back onLanguage:dockerfile activation event (#3928) * Add `SUPPORT.md` file (#3929) * Add `SUPPORT.md` file * Update SUPPORT.md * Revert back to normal ARM auth package (#3930) * moved util file to appropriate location * moved more files to appropriate locations * Separate task and client logic * better descriptions * added support for more Cpu Archs * corrected suggested list * added OS type to code more organized * redid imports to separate client and task * converted util method to Docker CLI Arg * revert advanced type declaration to simpler form * minor changes to naming * removed util file * edited json schema * Update src/runtimes/docker/utils/normalizeContainerOS.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * handle edge cases with util method * simplified json schema * tweaked file layout * use util in arg * Update src/runtimes/docker/utils/normalizeContainerOS.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * Update src/runtimes/docker/utils/getNativeArchitecture.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * Update src/runtimes/docker/contracts/ContainerClient.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * making getNativeArchitecture more robust * added comments to avoid confusion * small tweak to normalizePlatform * exported utils and imported them * handle more os edge cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stackie Jia <jsq2627@gmail.com>
alexyaang
added a commit
that referenced
this pull request
May 11, 2023
* scaffold tasks with native architecture * specified return architecture Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * moved util file to appropriate location * moved more util functions to appropriate folder * added stricter type cheking * refactored switch statements * refactored more switch statements * removed l10n * slightly changes json schema * Bump yaml from 2.2.1 to 2.2.2 (#3916) Bumps [yaml](https://github.com/eemeli/yaml) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add back onLanguage:dockerfile activation event (#3928) * Add `SUPPORT.md` file (#3929) * Add `SUPPORT.md` file * Update SUPPORT.md * Revert back to normal ARM auth package (#3930) * moved util file to appropriate location * moved more files to appropriate locations * Separate task and client logic * better descriptions * added support for more Cpu Archs * corrected suggested list * added OS type to code more organized * redid imports to separate client and task * converted util method to Docker CLI Arg * revert advanced type declaration to simpler form * minor changes to naming * removed util file * edited json schema * Update src/runtimes/docker/utils/normalizeContainerOS.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * handle edge cases with util method * simplified json schema * tweaked file layout * use util in arg * Update src/runtimes/docker/utils/normalizeContainerOS.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * Update src/runtimes/docker/utils/getNativeArchitecture.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * Update src/runtimes/docker/contracts/ContainerClient.ts Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> * making getNativeArchitecture more robust * added comments to avoid confusion * small tweak to normalizePlatform * exported utils and imported them * handle more os edge cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stackie Jia <jsq2627@gmail.com>
bwateratmsft
added a commit
that referenced
this pull request
May 16, 2023
|
We're going to release this in a 1.25.1 release to get it out sooner. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we rely on the inferred activation event for
dockerfile, but microsoft/vscode#179287 breaks this behavior for us.This PR adds back the
onLanguage:dockerfileactivation event in package.json.Fixes #3899