Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_code.visualstudio.com_VisualStudioCode_October 2018 version 1.29(Workbench)_Screenreader : Screenreader is not announcing brackets,colon,etc symbols in the code section. #3604

Closed
pranshu512 opened this issue Apr 24, 2020 · 6 comments
Assignees
Labels

Comments

@pranshu512
Copy link

pranshu512 commented Apr 24, 2020

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#P1_A11y_code.visualstudio.com_Apr2020;#A11ySev2;#A11yTCS;#A11yMAS;#Benchmark;#ChromiumEdge;#DesktopWeb;#MAS1.3.1;#Narrator;#Win10;#Visual Studio Code;#P1_code;#Chrome;#NVDA

Environment Details:
Application Name: code.visualstudio.com
#URL: https://code.visualstudio.com/updates/v1_29
Windows Version: Windows10
Browser version: Microsoft Edge Version 84.0.488.1 (Official build) dev (64-bit)

Repro Steps:
1)Launch the application url :
https://code.visualstudio.com/updates/v1_29
2)October 2018 (version 1.29) Page will get open.
3)Navigate to code section under "Workbench navigation commands".
4)Launch screen reader and check whether it announce brackets,colon,etc symbols in the code section or not.

Actual:
Screen reader is announcing only textual content in the code section and not announcing brackets,colon,etc symbols.

Same issue has been observed for all the brackets,colon,etc symbols present inside the code section in throughout application.

Same issue also observed with NVDA+Chrome.

Expected:
Screenreader should announce brackets,colon,etc symbols in the code section along with textual content.

User Impact:
Screen reader users will not understand the code properly.

Attachment link for Reference:
3604_ P1_A11y_code.visualstudio.com_VisualStudioCode_October 2018 version 1.29(Workbench)_Screenreader.zip

@gregvanl
Copy link

This is an issue with the shiki syntax highlighter https://github.com/octref/shiki

See shikijs/shiki#39

Marking as External

@Tyriar
Copy link
Member

Tyriar commented Jun 8, 2020

It looks to me like there is nothing wrong with the markup outlined in shikijs/shiki#39. It's even semantically correct in that it's inside a pre and a code block, if a screen reader isn't reading it correctly it's because the screen reader isn't good at reading code. I think this should be closed as designed.

@gregvanl
Copy link

gregvanl commented Jun 8, 2020

A VS Code engineer has reviewed this issue and believes it is a screen reader issue (see comment above).

@octref
Copy link
Contributor

octref commented Jun 12, 2020

Thanks @Tyriar, I'll close my upstream issue as well then.

@pranshu512 pranshu512 changed the title CELA P1_A11y_code.visualstudio.com_VisualStudioCode_October 2018 version 1.29(Workbench)_Screenreader : Screenreader is not announcing brackets,colon,etc symbols in the code section. P1_A11y_code.visualstudio.com_VisualStudioCode_October 2018 version 1.29(Workbench)_Screenreader : Screenreader is not announcing brackets,colon,etc symbols in the code section. Sep 25, 2020
@pranshu512 pranshu512 changed the title P1_A11y_code.visualstudio.com_VisualStudioCode_October 2018 version 1.29(Workbench)_Screenreader : Screenreader is not announcing brackets,colon,etc symbols in the code section. A11y_code.visualstudio.com_VisualStudioCode_October 2018 version 1.29(Workbench)_Screenreader : Screenreader is not announcing brackets,colon,etc symbols in the code section. Sep 28, 2020
@PoojaNamde
Copy link

@robole We are not able to find similar control in the https://code.visualstudio.com/api, could you please help

@Rama8345
Copy link

Verified the issue at https://code.visualstudio.com/api/get-started/extension-anatomy the issue is fixed. so, closing the bug. Please find attachment for reference.
Github tags:#Closed;

3604_Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants