Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Remove go 1.8 version for travis pipeline since it is not longer support #2060

Closed

Conversation

angulito
Copy link
Contributor

See
issue: here someone opens an issue to the go project explaining the current pipeline error for go#1.8:
image

nel-collector project: here you can see here they have removed the tests for go 1.8 since it's not longer support and now the go tools in the go project contains new syntax which go#1.8 does not support.

I've ran the pipeline here and now it works

@ramya-rao-a
Copy link
Contributor

Thanks for the PR @angulito

#2032 also is a PR to do the same. Like I have mentioned there, I dont want to stop support for Go 1.8

Feel free to follow the steps in #2032 (comment) instead to fallback to the older gocode for Go versions less than 1.10

@angulito
Copy link
Contributor Author

angulito commented Oct 31, 2018

Yep, I understand you @ramya-rao-a, although maybe it will be difficult to develop with open source libraries that maybe does not have support for Go 1.8 (I think it will happen in the short future).

  • I've created a new PR fixing a minor typo in the pipeline: Fix go get command in the pipeline. #2065
  • I've checked there is a new library which seems not supporting the Go 1.8 and I've seen you have opened an issue - so I guess we cannot fix that pipeline error right now.

Thanks to you.

@angulito angulito deleted the remove_go_1_8_no_longer_support branch October 31, 2018 14:32
@angulito
Copy link
Contributor Author

@ramya-rao-a also you can check here golint project has removed 1.8 version because it's not longer support too - https://travis-ci.org/golang/lint/jobs/444888944

@ramya-rao-a
Copy link
Contributor

I've updated the travis file to skip golint and gometalinter for 1.8
Also updated the tests to not test these 2 tools for 1.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants