Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt to install companion extension as needed #349

Closed
connor4312 opened this issue Feb 25, 2020 · 2 comments
Closed

Add prompt to install companion extension as needed #349

connor4312 opened this issue Feb 25, 2020 · 2 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@connor4312
Copy link
Member

Removing this as an extensionDependency as it caused failures when running in environments that didn't have UIs, like web. Instead we should show a prompt to install the companion if we see they don't have it, or a let them know that they can't debug browsers directly from web, as appropriate,

@connor4312 connor4312 reopened this Feb 25, 2020
@connor4312 connor4312 added this to the March 2020 milestone Feb 25, 2020
@roblourens
Copy link
Member

I think the companion extension should be builtin. We shouldn't have to have internet access to download a new component to enable functionality that should work out of the box. We can talk about this more if you want when you look at this again.

From Slack

All the default extensions do already get installed on the remote, I think that as long as the type is set it will still work even if it ends up in both places. We could optimize the download size by being smarter about which extensions are included in the remote package

@connor4312 connor4312 self-assigned this Mar 5, 2020
@connor4312 connor4312 added the debt Code quality issues label Mar 5, 2020
@connor4312
Copy link
Member Author

Added it as built-in, and added this message that's displayed in web:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants