fix: browser debugging in remotes not working #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1628 Moving to esbuild caused it to pull in the "wrapper.mjs" which doesn't expose the same API that `ws` normally does. See websockets/ws#2032 (comment)
roblourens
approved these changes
Mar 31, 2023
|
Windows failure is an existing flake I need to look at |
connor4312
added a commit
that referenced
this pull request
Mar 31, 2023
Fixes #1628 Moving to esbuild caused it to pull in the "wrapper.mjs" which doesn't expose the same API that `ws` normally does. See websockets/ws#2032 (comment)
Merged
|
Glad I helped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1628
Moving to esbuild caused it to pull in the "wrapper.mjs" which doesn't
expose the same API that
wsnormally does.See websockets/ws#2032 (comment)