Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workspace detection of nightly extension not working #1634

Merged
merged 1 commit into from
Apr 2, 2023
Merged

fix: workspace detection of nightly extension not working #1634

merged 1 commit into from
Apr 2, 2023

Commits on Apr 1, 2023

  1. fix: workspace detection of nightly extension not working 

    Previously, the package.json pulled in at the bundle step was the "nightly"-treated version, but this is no longer the case. This causes nightly to not be able to automatically determine it's running in a remote workspace, since the extensionId is wrong.

Instead, define the version, package name, and publisher as compile-time constants.

Refs #1628 (comment)
    @connor4312
    connor4312 committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    c0edfd6 View commit details
    Browse the repository at this point in the history