chore: 'hoist' package to reduce pipeline variance #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new build mode where the built assets will replace those in
the repo. This can be used in pipelines to avoid having the "workingDir"
that doesn't exist until later.
I also looked at modifying the checked-in package.json, but this was
difficult because:
(a) we modify the _name_ for nightly builds, which includes local
development, and having this change based on the build is noisy.
(b) there's just a lot of package.json (about 13k lines) which
uncompressed is sizable
|
the nightly 'failure' is just a test build where publishing as disabled |
joyceerhl
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new build mode where the built assets will replace those in the repo. This can be used in pipelines to avoid having the "workingDir" that doesn't exist until later.
I also looked at modifying the checked-in package.json, but this was difficult because:
(a) we modify the name for nightly builds, which includes local
development, and having this change based on the build is noisy.
(b) there's just a lot of package.json (about 13k lines) which
uncompressed is sizable