Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run by line is very slow when stepping through code in other cells/files/libraries #7246

Closed
Tracked by #5607
roblourens opened this issue Aug 24, 2021 · 2 comments
Closed
Tracked by #5607
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

I am testing with this notebook:

https://github.com/fastai/fastbook/blob/master/08_collab.ipynb

  • Find the cell with the code learn.fit_one_cycle(5, 5e-3)
  • Start a RBL session
  • While RBL is auto-stepping through code that we don't care about, the code runs very slowly. We expect this when debugging, but we also trigger expensive variables requests on every step. We should only do that when we will actually stop
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Aug 24, 2021
@DavidKutu DavidKutu added the verification-needed Verification of issue is requested label Aug 27, 2021
@DavidKutu DavidKutu added this to the August 2021 milestone Aug 27, 2021
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded verification-needed Verification of issue is requested labels Aug 27, 2021
@rzhao271
Copy link
Contributor

RBL still runs much slower than no RBL. Whereas with no RBL, the progressbar on that cell seems to gain over 10% per second, with RBL, the progressbar seems to gain around 1% per second. @roblourens is this approximately what you were seeing?

@roblourens
Copy link
Member Author

It will always be a little slower due to running in debug mode. There is also a little extra optimization we can do. I think @DavidKutu and I talked about this last week. Opened #7365

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants