Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue execution should use F5 keybinding #7746

Closed
Tracked by #5607
isidorn opened this issue Sep 29, 2021 · 4 comments
Closed
Tracked by #5607

Continue execution should use F5 keybinding #7746

isidorn opened this issue Sep 29, 2021 · 4 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-run-by-line
Milestone
Backlog

Comments

@isidorn
Copy link

isidorn commented Sep 29, 2021

Testing microsoft/vscode#133903

Continue execution uses the Ctrl + Enter keybinding. Why not F5 to be aligned with what we do for regular debugging?

Screenshot 2021-09-29 at 17 41 48
@DavidKutu
Copy link

it uses ctrl+enter because that's the keybinding to run in jupyter.

@DavidKutu DavidKutu transferred this issue from microsoft/vscode Sep 29, 2021
@roblourens
Copy link
Member

I think it could go either way, but F5 makes sense to me.

@greazer
Copy link
Member

greazer commented Sep 30, 2021

Ctrl+Enter, Shift+Enter and F5 should all continue to end of cell.

@greazer greazer added debt Code quality issues and removed needs-triage labels Sep 30, 2021
@greazer greazer added this to the October 2021 milestone Sep 30, 2021
@DavidKutu DavidKutu mentioned this issue Sep 30, 2021
Closed
78 tasks
@greazer greazer modified the milestones: October 2021, On Deck Oct 7, 2021
@greazer greazer added the bug Issue identified by VS Code Team member as probable bug label Oct 9, 2021
@roblourens
Copy link
Member

F5 does do continue. I think it's fine that ctrl+enter is the main default shortcut

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-run-by-line
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@roblourens @isidorn @greazer @rchiodo @DavidKutu