Display a message before opening file diffs in the browser (#575), fixes

#442
microsoft · May 23, 2019 · 0248f28 · 0248f28
1 parent c0ced7c
commit 0248f28
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/commands.ts b/src/commands.ts
@@ -151,6 +151,16 @@ export function registerCommands(context: vscode.ExtensionContext, prManager: Pu
 		vscode.commands.executeCommand('vscode.diff', parentFilePath, filePath, fileName, opts);
 	}));
 
+	context.subscriptions.push(vscode.commands.registerCommand('pr.openDiffGitHub', (uri: string) => {
+		vscode.window
+			.showWarningMessage('This file is either too large, of an unsupported type, or has only been renamed. Would you like to view it on GitHub?', 'Open in GitHub')
+			.then(result => {
+				if (result === 'Open in GitHub') {
+					vscode.commands.executeCommand('vscode.open', uri);
+				}
+			});
+	}));
+
 	context.subscriptions.push(vscode.commands.registerCommand('pr.deleteLocalBranch', async (e: PRNode) => {
 		const pullRequestModel = ensurePR(prManager, e);
 		const DELETE_BRANCH_FORCE = 'delete branch (even if not merged)';

diff --git a/src/view/treeNodes/fileChangeNode.ts b/src/view/treeNodes/fileChangeNode.ts
@@ -38,7 +38,7 @@ export class RemoteFileChangeNode extends TreeNode implements vscode.TreeItem {
 
 		this.command = {
 			title: 'show remote file',
-			command: 'vscode.open',
+			command: 'pr.openDiffGitHub',
 			arguments: [
 				vscode.Uri.parse(this.blobUrl)
 			]