Display a message before opening file diffs in the browser #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
force-pushed
the
github-redirect-message
branch
from
c18ca86
to
c72f2dc
Compare
RMacfarlane
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #442 by displaying a message with an 'Open in Github' link for diffs that come back without a
patchfield.Wording and everything is can be changed, I just put down what I thought was most clear. I wasn't comfortable trying to infer why the particular diff came back without a patch since I didn't find any documentation detailing which types of diffs are unsupported in the API.