Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Docker Container #60

Closed
wants to merge 3 commits into from
Closed

added Docker Container #60

wants to merge 3 commits into from

Conversation

mdxabu
Copy link

@mdxabu mdxabu commented Jul 22, 2023

added Dockerfile and runned the App.java in Docker container 🐋

@mdxabu
Copy link
Author

mdxabu commented Jul 22, 2023

@microsoft-github-policy-service agree

@mdxabu mdxabu closed this Jul 22, 2023
@mdxabu mdxabu reopened this Jul 22, 2023
@bamurtaugh
Copy link
Member

Thank you for taking the time to put together this PR!

The dev container in this repo is based on the Java template in our dev containers org: https://github.com/devcontainers/templates. It's based on our prebuilt Java image in the same org. There's additional info here: https://containers.dev/guide/dockerfile.

Switching to an image-based config rather than Dockerfile-based is a somewhat recent path we've chosen for our dev container references / resources, and we really value the community's feedback. We have an open issue to discuss the presence of Dockerfiles in our templates - if that was part of the motivation for this PR, it'd be great to get your thoughts in our issue: devcontainers/templates#135.

With the above context in mind, I don't think we'll proceed with this PR at this time. If you have any questions or there were other motivations I might not have mentioned, please just let us know. Thanks so much!

@bamurtaugh bamurtaugh mentioned this pull request Jul 24, 2023
@mdxabu
Copy link
Author

mdxabu commented Jul 24, 2023

Thanks for the clarification, @bamurtaugh

@mdxabu mdxabu closed this by deleting the head repository Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants