Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR No translation found for %abc% #981

Closed
tamuratak opened this issue May 20, 2024 · 2 comments · Fixed by #983
Closed

ERROR No translation found for %abc% #981

tamuratak opened this issue May 20, 2024 · 2 comments · Fixed by #983
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@tamuratak
Copy link

vsce v2.26.1 raises ERROR No translation found for %abc% when executing vsce package.

Steps to reproduce:

  1. Add the following to package.json of the extension:
	"contributes": {
		"configuration": {
			"title": "Hello World",
			"type": "object",
			"properties": {
				"someString": {
					"type": "string",
					"default": "%abc%"
				}
			}
		}
	},
  1. Execute vsce package.

vsce should not validate the default values of configurations, which can be any value.

@benibenj benibenj self-assigned this May 22, 2024
@benibenj benibenj added the bug Issue identified by VS Code Team member as probable bug label May 22, 2024
@benibenj benibenj added this to the May 2024 milestone May 22, 2024
benibenj added a commit that referenced this issue May 22, 2024
@benibenj
Copy link
Contributor

It seems like translations are validated even when there is no NLS file. I changed it such that NLS validation only happens when a NLS file is present

@benibenj
Copy link
Contributor

verification by code review: https://github.com/microsoft/vscode-vsce/pull/983/files

@lramos15 lramos15 added the verified Verification succeeded label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants