Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 429 Retry-After #102391

Closed
Tyriar opened this issue Jul 13, 2020 · 2 comments
Closed

Support 429 Retry-After #102391

Tyriar opened this issue Jul 13, 2020 · 2 comments
Assignees
@sandy081
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 13, 2020 •
edited
Loading

The sync server will soon support throttling via 429 with the Retry-After header that indicates the number of seconds to wait before trying again. When Retry-After is set, sync should be suspended (silently) for the period specified instead of being turned off.
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jul 13, 2020
@Tyriar Tyriar added this to the July 2020 milestone Jul 13, 2020
@Tyriar Tyriar closed this as completed Jul 14, 2020
@Tyriar Tyriar reopened this Jul 14, 2020
@microsoft microsoft deleted a comment Jul 14, 2020
@Tyriar Tyriar reopened this Jul 14, 2020
@sandy081 sandy081 removed the *duplicate Issue identified as a duplicate of another issue(s) label Jul 14, 2020
@sandy081
Copy link
Member

When server returns retry-after header with 429 status, client suspends auto sync until mentioned time and enables auto sync after.

[2020-07-20 19:00:33.137] [userDataSync] [info] Auto Sync: Started
[2020-07-20 19:00:33.137] [userDataSync] [info] Auto Sync: Triggered by Interval
[2020-07-20 19:00:33.731] [userDataSync] [info] Auto Sync: Suspended until 2020-07-20T19:02:33.730Z because server is not accepting requests until then.
[2020-07-20 19:00:33.731] [userDataSync] [info] Auto sync: Canelled sync that is in progress
[2020-07-20 19:00:33.731] [userDataSync] [info] Auto Sync: Stopped
[2020-07-20 19:00:33.733] [userDataSync] [error] TooManyRequestsAndRetryAfter (UserDataSyncError) syncResource:unknown operationId:ddfabf1187de472a88b05bcfe32c9a6c: GET request 'https://server/v1/manifest' failed because of too many requests (429).
    at UserDataSyncStoreService.request (file:///Users/sandy081/work/vscode/out/vs/platform/userDataSync/common/userDataSyncStoreService.js:265:19)
    at async UserDataSyncStoreService.manifest (file:///Users/sandy081/work/vscode/out/vs/platform/userDataSync/common/userDataSyncStoreService.js:173:29)
    at async UserDataSyncService.createSyncTask (file:///Users/sandy081/work/vscode/out/vs/platform/userDataSync/common/userDataSyncService.js:97:28)
    at async AutoSync.doSync (file:///Users/sandy081/work/vscode/out/vs/platform/userDataSync/common/userDataAutoSyncService.js:323:33)
[2020-07-20 19:02:33.735] [userDataSync] [info] Auto Sync: Started
[2020-07-20 19:02:33.735] [userDataSync] [info] Auto Sync: Triggered by Interval

joaomoreno pushed a commit that referenced this issue Jul 21, 2020
@sandy081 @joaomoreno
Fix #102391
d64b5a5
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Aug 3, 2020
@sandy081
Copy link
Member

sandy081 commented Aug 3, 2020

@Tyriar Can you please verify ?

@Tyriar Tyriar added the verified Verification succeeded label Aug 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@Tyriar @sandy081 and others