VSCode hangs and crashes upon closing pwsh terminal instance

[amunger3]

Issue Type: Bug

Upon closing a terminal instance, VSCode will become unresponsive for a mintute or so before a dialog appears asking if you'd like to reload it. It occurs regardless of whether extensions are enabled but only appears to happen if the shell being closed is PowerShell Core. It doesn't matter whether its the Integrated PowerShell Terminal or otherwise.

Steps to reproduce:

1. open VSCode (it happens whether or not there is a folder open)

2. Set default shell to PowerShell Core (mine is v7.0.3 if it is relevant); open a new terminal.

3. Close the instance (don't just hide it)

4. The VSCode window should now be unresponsive.

(P.S. I suppose it could be a PowerShell issue not specific to VSCode. If so, I apologize for addressing the wrong party.)

VS Code version: Code 1.47.3 (91899dc, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.20185

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: enabled rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	11.84GB (2.35GB free)
Process Argv
Screen Reader	no
VM	0%

[IllusionMH]

Most likely #76548 but that was for old Windows builds, not Insiders(Dev Channel).

/cc @Tyriar is it still an issue not only in old Windows builds?

[Tyriar]

@IllusionMH this one is an issue in new Windows 10 builds (1903+), there's a fix done for node-pty (microsoft/node-pty#415) but electron doesn't support workers in renderer processes (electron/electron#18540 (comment)) so we need to wait until the terminal process is hosted in a node process that's a child of the main process (#74620).