Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to split bundles in Notebook Renderers #109932

Closed
DonJayamanne opened this issue Nov 3, 2020 · 4 comments
Closed

Unable to split bundles in Notebook Renderers #109932

DonJayamanne opened this issue Nov 3, 2020 · 4 comments
Assignees
@rebornix @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
November 2020

Comments

@DonJayamanne
Copy link
Contributor

  • Version: 1.51.0-insider
  • OS: Darwin x64 19.6.0

Steps to Reproduce:

  1. Try the sample renderer https://github.com/microsoft/vscode-notebook-renderer-starter
  2. It does not work

We get an error Error loading preloads: Cannot read property 'src' of null
Looks like we are no longer emitting a script tag for the preloads.

@rebornix @connor4312 /cc

Does this issue occur when all extensions are disabled?: N/A
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Nov 3, 2020
@connor4312
Copy link
Member

There's now a scriptUrl global you can use instead of document.currentScript.src

@connor4312 connor4312 added this to the November 2020 milestone Nov 4, 2020
@connor4312
Copy link
Member

See microsoft/vscode-generator-code@ea8867d for an example

@connor4312
Copy link
Member

Fyi @vijayupadya @kjcho-msft this is new contract

@roblourens roblourens added the verified Verification succeeded label Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
5 participants
@roblourens @rebornix @DonJayamanne @connor4312 and others