Adopt StorageTarget

[bpasero]

If you own a call to IStorageService#store, please adopt IStorageService#store2 where a new argument is required:

• StorageTarget.USER: sync it across machines
• StorageTarget.MACHINE: do NOT sync it

As a rule of thumb, StorageTarget.USER should be used in almost all cases unless the state is very specific to the machine (e.g. file paths are used, or window dimensions and sizes).

Note: even though we do not sync workspace UI state yet, it would still be good to adopt this new method so that we are ready in the future.

Here is a list of areas:
StorageService

• workbenchThemeService @aeschli
• productIconThemeData @aeschli
• fileIconThemeData @aeschli
• remoteExplorerService @alexr00
• authenticationService @RMacfarlane
• mainThreadAuthentication @RMacfarlane
• runAutomaticTasks @alexr00
• abstractTaskService @alexr00
• scmService @meganrogge (history related)
• experimentService @sbatten

Memento (look for legacygetMemento)

• experimentService @sbatten
• webviewPane @mjbvz
• searchEditorInput @JacksonKearl
• notebookServiceImpl @rebornix
• notebookEditorWidget @rebornix
• contributedCustomEditors @mjbvz

Fyi I will go over a few not mentioned here that are straight forward to adopt.

[alexr00]

@bpasero how does this interact with StorageScope.WORKSPACE?

[bpasero]

@alexr00 I tried to explain this above:

Note: even though we do not sync workspace UI state yet, it would still be good to adopt this new method so that we are ready in the future.

Today we don't sync workspace UI state, but we may in the future. Only put StorageTarget.USER for StorageScope.WORKSPACE if the data does not contain machine specific things (like file paths).

[alexr00]

I should have read more carefully, thank you.

[bpasero]

Thanks for a lot of changes already. I forgot to list the references to memento object that also needs adoption. The new list is:

StorageService

• workbenchThemeService @aeschli
• productIconThemeData @aeschli
• fileIconThemeData @aeschli
• remoteExplorerService @alexr00
• authenticationService @RMacfarlane
• mainThreadAuthentication @RMacfarlane
• runAutomaticTasks @alexr00
• abstractTaskService @alexr00
• scmService @meganrogge (history related)
• experimentService @sbatten

Memento (look for legacygetMemento)

• experimentService @sbatten
• webviewPane @mjbvz
• searchEditorInput @JacksonKearl
• notebookServiceImpl @rebornix
• notebookEditorWidget @rebornix
• contributedCustomEditors @mjbvz

[bpasero]

Thanks, only a few left. Ping @rebornix & @RMacfarlane

[bpasero]

Down to only these:

[rebornix]

@bpasero I added ScopeTarget in notebook world, the legacygetMemto can be removed now.