-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy Authentication Required error on login #111824
Comments
is there any progroess? I have the same question. |
@chrmarti For extensions, is there anything needed to support proxies, or is it expected that fetch requests would just work? |
There is support when you end up using the Chromium network stack, but none at the moment if you end up using Node.js' http/s module. Could you point me at the settings sync code doing the request? (Related: #12588) |
Ah, I'm using node fetch. The request is done here:
|
That uses http/s from Node and our proxy support added to that currently does not support authentication. Except: If it's basic auth, you could try setting the |
@chrmarti could we switch to the network stack that does honor the vscode http proxies? |
Extension don't have direct access to the Chromium network stack. There is the '_workbench.downloadResource' command to allow for simple GET requests, but no command yet for POST requests. Ideally we would implement support for proxy auth in our existing proxy support for the Node.js API, but I don't have a timeline for that at the moment. (That would also benefit all other extensions.) |
Bump on this. Any plans to add proxy authentication support for the built in settings sync? |
@fromthewoods Have you tried setting the |
@chrmarti yes that works, but I'd rather not have to expose my password in env variables. It seems that having this configured also breaks other applications that use this env var. Chocolately for example is confused by this entry. |
All vscode extensions, including the Microsoft and GitHub Authentication extensions, still suffer from a lack of solution - is there a path forward to making extensions use Chromium's Fetch, which is aware of OS level proxy settings, instead of Node's fetch, which doesn't really honor settings.json proxy settings? Perhaps @TylerLeonhardt, you in a place to push the team on this, as I guess you might be closest to the telemetry on failed attempts, especially due to proxy problems? |
@fromthewoods just to be clear, @chrmarti was recommending setting |
I'm coming from #178213. I don't know what my proxy address is so I cannot set |
/duplicate #12588 |
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines. Happy Coding! |
when setting sync using my github or Microsoft accout, this error is occured
Steps to Reproduce:
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: