Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Authentication Required error on login #111824

Closed
gamersover opened this issue Dec 3, 2020 · 17 comments
Closed

Proxy Authentication Required error on login #111824

gamersover opened this issue Dec 3, 2020 · 17 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@gamersover
Copy link

gamersover commented Dec 3, 2020

when setting sync using my github or Microsoft accout, this error is occured

[Info  - 15:16:55.21] Logging in...
[Info  - 15:17:03.563] Exchanging code for token...
[Error  - 15:17:03.678] Proxy Authentication Required
  • VSCode Version: 1.51.1
  • OS Version: windows10 20H2/ubuntu 20.04

Steps to Reproduce:

  1. open sync setting
  2. select github or Microsoft

Does this issue occur when all extensions are disabled?: Yes

@sandy081 sandy081 assigned RMacfarlane and unassigned sandy081 Dec 3, 2020
@RMacfarlane RMacfarlane added the authentication Issues with the Authentication platform label Dec 3, 2020
@cclinuxer
Copy link

is there any progroess? I have the same question.

@RMacfarlane
Copy link
Contributor

@chrmarti For extensions, is there anything needed to support proxies, or is it expected that fetch requests would just work?

@RMacfarlane RMacfarlane added this to the Backlog milestone May 7, 2021
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label May 7, 2021
@RMacfarlane RMacfarlane changed the title Proxy Authentication Required Proxy Authentication Required error on login May 7, 2021
@chrmarti
Copy link
Contributor

There is support when you end up using the Chromium network stack, but none at the moment if you end up using Node.js' http/s module. Could you point me at the settings sync code doing the request? (Related: #12588)

@RMacfarlane
Copy link
Contributor

Ah, I'm using node fetch. The request is done here:

const result = await fetch(endpoint, {

@chrmarti
Copy link
Contributor

That uses http/s from Node and our proxy support added to that currently does not support authentication. Except: If it's basic auth, you could try setting the HTTP Proxy user setting to a http://username:password@proxyhost value.

@TylerLeonhardt
Copy link
Member

@chrmarti could we switch to the network stack that does honor the vscode http proxies?

@chrmarti
Copy link
Contributor

Extension don't have direct access to the Chromium network stack. There is the '_workbench.downloadResource' command to allow for simple GET requests, but no command yet for POST requests.

Ideally we would implement support for proxy auth in our existing proxy support for the Node.js API, but I don't have a timeline for that at the moment. (That would also benefit all other extensions.)

@fromthewoods
Copy link

Bump on this. Any plans to add proxy authentication support for the built in settings sync?

@chrmarti
Copy link
Contributor

@fromthewoods Have you tried setting the HTTP Proxy user setting to a http://username:password@proxyhost value?

@fromthewoods
Copy link

fromthewoods commented Sep 9, 2021

@chrmarti yes that works, but I'd rather not have to expose my password in env variables. It seems that having this configured also breaks other applications that use this env var. Chocolately for example is confused by this entry.

@Glutnix
Copy link

Glutnix commented Jan 31, 2023

All vscode extensions, including the Microsoft and GitHub Authentication extensions, still suffer from a lack of solution - is there a path forward to making extensions use Chromium's Fetch, which is aware of OS level proxy settings, instead of Node's fetch, which doesn't really honor settings.json proxy settings?

Perhaps @TylerLeonhardt, you in a place to push the team on this, as I guess you might be closest to the telemetry on failed attempts, especially due to proxy problems?

@TylerLeonhardt
Copy link
Member

@fromthewoods just to be clear, @chrmarti was recommending setting http.proxy the VS Code setting. Not an environment variable. I don't think that should influence running Chocolatey commands. Unless I'm misunderstanding what you're saying?

@MH-ABE
Copy link

MH-ABE commented Mar 30, 2023

I'm coming from #178213. I don't know what my proxy address is so I cannot set http.proxy, and it would be kerberos authenticated anyway: #12588 (comment)
By the way, for me Microsoft account login works for settings sync but not Github?

@chrmarti
Copy link
Contributor

@MH-ABE Maybe join #177139 as that is about certificates.

@antonioacg
Copy link

@TylerLeonhardt
Copy link
Member

/duplicate #12588

@TylerLeonhardt TylerLeonhardt removed bug Issue identified by VS Code Team member as probable bug authentication Issues with the Authentication platform labels Dec 13, 2023
@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 13, 2023
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.