Getting started page shows enable settings sync even when already enabled

[lramos15]

Steps to Reproduce:

1. Open getting started page
2. Go through quick setup
3. 🐛 It wants me to enable setting sync, and clicking the button brings up the sign in option even though I already have settings sync enabled.

[JacksonKearl]

Is this latest insiders? I saw that yesterday and beleive I fixed it but possibly not.

[lramos15]

Yes this is latest insiders.

[JacksonKearl]

cc @sandy081 I listen on:

vscode/src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStartedService.ts

Lines 187 to 190 in 5c6836e

	if (userDataAutoSyncEnablementService.isEnabled()) { this.progressByEvent('sync-enabled'); }
	this._register(userDataAutoSyncEnablementService.onDidChangeEnablement(() => {
	if (userDataAutoSyncEnablementService.isEnabled()) { this.progressByEvent('sync-enabled'); }
	}));

but this seems to not always catch sync being active, do you know a better way to check this?

[sandy081]

This should be enough. IUserDataAutoSyncEnablementService is the truth for settings sync enablement. Can you repro it from sources?

[lramos15]

I can reproduce this sometimes from sources. It seems to be pretty hit or miss with that event.
For example enabling settings sync and then opening the getting started page will show the entry but have it checked. Disabling settings sync and then restarting oss will not unhide the entry. I'm not sure what's going on or what's a good repro for it.

[sandy081]

@JacksonKearl I just debugged running from sources and line 187 and line 189 above are getting executed as expected when settings sync is on/off or enabled/disabled.

[JacksonKearl]

Thanks! Thats, interesting, it may be that the enablement message gets delivered before the task is around to be marked complete.

[JacksonKearl]

Going to take this as part of #122570