Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff chunk contains an unchanged line #121436

Closed
bersbersbers opened this issue Apr 16, 2021 · 3 comments
Closed

Diff chunk contains an unchanged line #121436

bersbersbers opened this issue Apr 16, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@bersbersbers
Copy link

Issue Type: Bug

First file:

if (cond) {
    cmd
}

Second file:

if (cond) {
    if (other_cond) {
        cmd
    }
}

The diff:
image

The diff chunk contains the same final line in both files - it could/should be shorter.

VS Code version: Code - Insiders 1.56.0-insider (25785b9, 2021-04-15T05:14:21.699Z)
OS version: Windows_NT x64 10.0.19043
Remote OS version: Linux x64 5.3.18-lp152.44-default

@vscodebot
Copy link

vscodebot bot commented Apr 16, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bersbersbers
Copy link
Author

The problem is not restricted to just single lines. This could be 3 changed lines of code - instead, it's 10:

image

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues labels Jun 5, 2021
@alexdima alexdima added this to the June 2021 milestone Jun 5, 2021
@alexr00 alexr00 added the verified Verification succeeded label Jul 1, 2021
@bersbersbers
Copy link
Author

Thank you :)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@alexdima @bersbersbers @alexr00 and others