Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give extensions a way to know that cells are closed/disposed #123269

Closed
jrieken opened this issue May 7, 2021 · 1 comment
Closed

Give extensions a way to know that cells are closed/disposed #123269

jrieken opened this issue May 7, 2021 · 1 comment
Assignees
@jrieken
Milestone
May 2021

Comments

@jrieken
Copy link
Member

jrieken commented May 7, 2021

A notebook cell should know that it has been removed from the document and disallow certain operations, e.g be in dettached mode
@jrieken jrieken self-assigned this May 7, 2021
@jrieken jrieken added this to the May 2021 milestone May 7, 2021
@jrieken jrieken changed the title Given extension a way to know that cells are closed/disposed Give extensions a way to know that cells are closed/disposed May 7, 2021
@jrieken
Copy link
Member Author

jrieken commented May 7, 2021

The "API" way is to check whether the index is -1 or not. When creating a cell execution this is now checked and reason for failure

jrieken added a commit that referenced this issue May 7, 2021
@jrieken
check that a cell is still "alive" and only iff so start executing it, …
b177753 
…fixes #123269
jrieken added a commit that referenced this issue May 7, 2021
@jrieken
some jsdoc for NotebookCell, esp for #123269
0f47716
@jrieken jrieken closed this as completed May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
May 2021
Development

No branches or pull requests
1 participant
@jrieken