RemoteHub: Continue On from web does not check if git is existing

[aeschli]

I have a brand new Windows install

• Open a repo using RemoteHub
• Run Continue On: Clone Repository Locally
• Nothing happens

Looking in the Dev Tools Console I realize that I don't yet Git installed

-> should show an error message

Or even, deluxe, let me open the Git webpage.

[joyceerhl]

@lszomoru Is this something that would be handled in the git extension since that contributes the clone command?

[lszomoru]

@joyceerhl, yes, that makes sense to me since there is already code that handles the detection of git in the git extension.

[joyceerhl]

Today Continue On > clone locally still silently errors out if git is missing. Talked with @digitarald this morning, he mentioned

• Ideally we have a one click in-product install for git: Explore a more helpful no-git-found state for SCM #136408
• Missing git should not be a no-op

At minimum I think we could show a dialog with a link to https://aka.ms/vscode-install-git

vscode/src/vs/workbench/contrib/welcomeGettingStarted/common/gettingStartedContent.ts

Line 473 in 59942f7

description: localize('gettingStarted.installGit.description.interpolated', "Install Git to track changes in your projects.\n{0}", Button(localize('installGit', "Install Git"), 'https://aka.ms/vscode-install-git')),

[joyceerhl]

The reason for this happening is that the git uri handler and most git commands are not even registered if git is missing on extension activation

vscode/extensions/git/src/main.ts

Lines 206 to 208 in 8c254bb

	if (!/Git installation not found/.test(err.message || '')) {
	throw err;
	}

So the window receives focus on the protocol handler invocation but of course nothing is available to handle the uri. I opened a PR to fix this in the git uri handler specifically: #159505

[aeschli]

I still see the problem. Nothing happens after Clone Repository Locally and Open on Desktop
(Remote Repositories v0.21.2022092801)

Dev tools show:

console.ts:137 [Extension Host] Git installation not found. (at console. (/home/aeschli/Downloads/code-insider-x64-1664343998/VSCode-linux-x64/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:90:142292))
console.ts:137 [Extension Host] rejected promise not handled within 1 second: Error: command '_codespaces.setActiveRepository' not found (at console. (/home/aeschli/Downloads/code-insider-x64-1664343998/VSCode-linux-x64/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:90:142292))
console.ts:137 [Extension Host] stack trace: Error: command '_codespaces.setActiveRepository' not found
at S._tryExecuteCommand (vscode-file://vscode-app/home/aeschli/Downloads/code-insider-x64-1664343998…nux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1713:3532)
at S.executeCommand (vscode-file://vscode-app/home/aeschli/Downloads/code-insider-x64-1664343998…nux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1713:3414) (at console. (/home/aeschli/Downloads/code-insider-x64-1664343998/VSCode-linux-x64/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:90:142292))
log.ts:313 ERR command '_codespaces.setActiveRepository' not found: Error: command '_codespaces.setActiveRepository' not found
at S._tryExecuteCommand (vscode-file://vscode-app/home/aeschli/Downloads/code-insider-x64-1664343998…nux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1713:3532)
at S.executeCommand (vscode-file://vscode-app/home/aeschli/Downloads/code-insider-x64-1664343998…nux-x64/resources/app/out/vs/workbench/workbench.desktop.main.js:1713:3414)

[joyceerhl]

@aeschli question about your setup, are you connected to a Linux remote in this case?

[joyceerhl]

This works as expected for me on a clean Windows VM with no git installed:

[aeschli]

I tested on Linux and to test, I renamed the git symbolic link: sudo mv /usr/bin/git /usr/bin/git2

[joyceerhl]

Marking this issue (specifically from web to desktop) as verified based on #162235 (comment).