Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full-screen mode on iOS #124973

Closed
tianzerun opened this issue May 31, 2021 · 8 comments
Closed

Enable full-screen mode on iOS #124973

tianzerun opened this issue May 31, 2021 · 8 comments
Assignees
Labels
info-needed Issue requires more information from poster ios-ipados under-discussion Issue is under discussion for relevance, priority, approach

Comments

@tianzerun
Copy link

Would you consider enabling the full-screen mode for vscode on iOS Safari? This can be done by adding the meta tag <meta name="apple-mobile-web-app-capable" content="yes">. It gets rid of the browser's user interface so more screen space is available for users.

Moreover, adding the shrink-to-fit=no viewport attribute prevents the default scaling down behavior when content overflows.

<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0, user-scalable=no">

Github Codespaces looks pretty good by having them on.
11a9d6be23284cb0e0c554a9ff3334f0

@bpasero bpasero assigned isidorn and unassigned bpasero Jun 1, 2021
@isidorn isidorn added ios-ipados under-discussion Issue is under discussion for relevance, priority, approach labels Jun 1, 2021
@isidorn
Copy link
Contributor

isidorn commented Jun 1, 2021

@tianzerun thanks for the suggestion. This makes sense and I plan to try it out.

@isidorn isidorn modified the milestones: May 2021, June 2021 Jun 1, 2021
@isidorn
Copy link
Contributor

isidorn commented Jul 1, 2021

Did not have time unfortunately, pushing out to August, since in July I am on vacation.

@isidorn isidorn modified the milestones: June 2021, August 2021 Jul 1, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 20, 2021

@tianzerun I apologise for the slow response, I was on summer vacation.
First of all, we definitely want to enable full screen. Similar discussion #106972

However I just tried the changes you propose and I could not see any change in behaviour.
I also tried Codespaces with what they have and I could not get into full-screen mode on my iPad. Is this something only for mobile?
If yes what are the exact changes that you see?

@bpasero I am not sure if we are open to these changes that might potentially only improve the phone experience. I am in general ok with this, since users might use the phone for some simple browsing.

fyi @alefragnani

@isidorn isidorn added the info-needed Issue requires more information from poster label Aug 20, 2021
@isidorn isidorn removed this from the August 2021 milestone Aug 20, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2021

Once more info is provided I would open this issue. Thanks!

@LeuisKen
Copy link
Contributor

LeuisKen commented Sep 15, 2021

I test this meta view port on iPad that works:

<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0, minimal-ui"/>
<meta name="apple-mobile-web-app-capable" content="yes" />

It looks like that minimal-ui makes this feature work, maybe @isidorn could have a try.

@hkhking
Copy link

hkhking commented Sep 15, 2021

i get it 😄

IMG_06A1EE9671A8-1

os: ipados 15
device:ipad pro 2021

step:
1、 pin icon to desktop
2、open & reload

@isidorn
Copy link
Contributor

isidorn commented Sep 17, 2021

@LeuisKen I just tried your suggestion and it still does not work for me.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster ios-ipados under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

6 participants
@bpasero @isidorn @LeuisKen @hkhking @tianzerun and others