Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"files.autoSave": "onFocusChange" causes issues with virtual file systems #125124

Closed
eamodio opened this issue Jun 1, 2021 · 5 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Jun 1, 2021

Virtual file system is not available notification when restoring opened editors

notification

Steps:

  1. Ensure you have RemoteHub insiders installed (and ensure RemoteHub stable is disabled).
  2. Open a remote repository, via Open Remote Repository... from the command palette
  3. Open a file from the remote repository
  4. Now reload the window or close and re-open the remote repository

It seems to only happen we the "files.autoSave": "onFocusChange" set, if I remove that it works normally.

Here is the call stack of where it happens too:
image

@eamodio eamodio changed the title Virtual file system is not available notification when restoring opened editors "files.autoSave": "onFocusChange" causes issues with virtual file systems Jun 1, 2021
@eamodio
Copy link
Contributor Author

eamodio commented Jun 1, 2021

Another instance of this can be reproduced with Git or GitLens, but has a slightly different behavior.

Steps:

  1. Edit a file, and in the SCM view, right-click on the edited file and choose Open File (HEAD)
  2. Reload the workspace
  3. 🐛 you will now see a save dialog for that file

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editors Managing of editor widgets in workbench window labels Jun 1, 2021
@bpasero bpasero added this to the May 2021 milestone Jun 1, 2021
@bpasero bpasero closed this as completed in b743bf6 Jun 1, 2021
@bpasero
Copy link
Member

bpasero commented Jun 1, 2021

A regression from EditorInputCapabilities I added a few days ago. Apparently FileEditorInput can be untitled too 🐙

@eamodio
Copy link
Contributor Author

eamodio commented Jun 2, 2021

@bpasero With today's insiders (which should have this fix), I'm still seeing the same behavior.

@eamodio eamodio reopened this Jun 2, 2021
@bpasero bpasero modified the milestones: May 2021, Backlog Jun 2, 2021
@bpasero bpasero added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug workbench-editors Managing of editor widgets in workbench window labels Jun 2, 2021
@bpasero bpasero removed this from the Backlog milestone Jun 2, 2021
@bpasero
Copy link
Member

bpasero commented Jun 2, 2021

Ok, I don't see it 🤷

@eamodio
Copy link
Contributor Author

eamodio commented Jun 2, 2021

With the 2nd insiders release that came out today, I'm not longer seeing it. Not sure why I was before.

@eamodio eamodio closed this as completed Jun 3, 2021
@eamodio eamodio added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 3, 2021
@eamodio eamodio added this to the May 2021 milestone Jun 3, 2021
@eamodio eamodio added the verified Verification succeeded label Jun 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@eamodio @bpasero and others