Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format On Save Is Triggered After Writing Content To Disk (Insiders) #128730

Closed
hediet opened this issue Jul 15, 2021 · 4 comments
Closed

Format On Save Is Triggered After Writing Content To Disk (Insiders) #128730

hediet opened this issue Jul 15, 2021 · 4 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug formatting Source formatter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2021

Comments

@hediet
Copy link
Member

hediet commented Jul 15, 2021 •
edited
Loading

recording

I can reproduce this when only Prettier is enabled.
I cannot reproduce this in VS Code stable.

In the Gif, I only hit Space, then Ctrl + S, then Ctrl + S again.

You can see that you have to trigger save twice.
@jrieken
Copy link
Member

jrieken commented Jul 15, 2021

I can reproduce this when only Prettier is enabled.

Prettier bug? Please try with the builtin TS formatter

@hediet
Copy link
Member Author

hediet commented Jul 15, 2021

the same happens with the builtin ts formatter.

@jrieken
Copy link
Member

jrieken commented Jul 15, 2021

caused by #127849

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug formatting Source formatter issues labels Jul 15, 2021
@jrieken jrieken added this to the July 2021 milestone Jul 15, 2021
@jrieken
Copy link
Member

jrieken commented Jul 15, 2021

Misses awaits from calling formatWholeFile

@gjsjohnmurray gjsjohnmurray mentioned this issue Jul 16, 2021
Closed
@alexr00 alexr00 added the verified Verification succeeded label Jul 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug formatting Source formatter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2021
Development

No branches or pull requests
4 participants
@jrieken @hediet @alexr00 and others