Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability "souce control" tree element filtering bad #140563

Closed
shoffmeister opened this issue Jan 12, 2022 · 5 comments
Closed

Usability "souce control" tree element filtering bad #140563

shoffmeister opened this issue Jan 12, 2022 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality scm General SCM compound issues ux User experience issues

Comments

@shoffmeister
Copy link

shoffmeister commented Jan 12, 2022

Issue Type: Bug

The "Souce Control" view of VS code allows for element filtering in its tree view (I like that!)

Alas, this filtering suffers from a few usability concerns which make the feature less functional than (easily) feasible.

Lets start with a screenshot which I will use to illustrate those challenges:

image

a) visually detached filter

Notice how I "enabled" treeview element filtering by typing "care" - see upper right corner. But also notice the large gap between the typed "care" and the filtered elements (thanks to the commit message box).

Request: Make typed "care" appear above the "Changes" list (lower right corner of the Commit message), not in the upper right corner of the "Source Control" panel

b) filtering (partially) collapsed tree-perspective treeview

The treeview can be switched between a list and tree perspective; I much prefer the tree perspective. The tree perspective may be (partially) collapsed.

Filtering of elements works perfectly in any perspective, but in tree perspective (partially) collapsed elements are a pain: there does not seem to be any way to "expand all" or "collapse all", such that the effects of filtering become visible.

Request: Provide a means to at least "expand all" (e.g. [+]) and possibly "collapse all" ([-])

For reference, the plain "Explorer" panel does have a "collapse all" ([-]) icon in the top right corner - but also lacks an "expand all" (e.g. [+]) icon

So, generally, the lack of means to "expand all" has negative impact on the usability to filter that tree view, in particular for directories (workspaces) with a large number of (deeply nested) directories.

VS Code version: Code 1.63.2 (899d46d, 2021-12-15T09:39:46.686Z)
OS version: Linux x64 5.15.13-200.fc35.x86_64
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2904)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
rasterization: disabled_software
skia_renderer: enabled_on
video_decode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 31.31GB (15.31GB free)
Process Argv --disable-extensions --crash-reporter-id 80e0ae97-0bc4-4a76-8337-f435f2ec1554
Screen Reader no
VM 100%
DESKTOP_SESSION /usr/share/xsessions/plasmax11
XDG_CURRENT_DESKTOP KDE
XDG_SESSION_DESKTOP KDE
XDG_SESSION_TYPE x11
Extensions disabled
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vscop804cf:30404767
vs360:30404995
vsrem710:30416614
vsccppwtstudy:30421978

@joaomoreno joaomoreno assigned lszomoru and unassigned joaomoreno Jan 12, 2022
@lszomoru lszomoru added scm General SCM compound issues ux User experience issues labels Jan 13, 2022
@lszomoru
Copy link
Member

//cc @misolori

@devhl-labs
Copy link

+1

I'm also looking for the ability to filter out diffs that are only line endings and/or whitespace. In this image, you can see that I have over 1000 diffs, but they are all line endings(I think???). It's impossible to for me to review without filtering out the line ending diffs.

image

@lszomoru lszomoru added the feature-request Request for new features or functionality label Dec 6, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Dec 6, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality scm General SCM compound issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants