Introduce sounds for: inline suggestions, quick fixes and other potential cases #141635
Comments
isidorn
added
feature-request
|
Is this also the issue where we track the proposed volume changes to the sounds that were introduced in #130565 ? |
|
I wonder if we could use this for indentation sounds, for systems like MacOS or ChromeOS where the screen readers don't natively support automatic reporting of indentation? I put ChromeOS in there because one can use VS Code on the web now. |
|
@zersiax yes, we could also use this issue to track that request. |
|
Would it be possible to introduce a sound to indicate the presence of a warning on the line? |
|
@devinprater While I'd love your suggestion, I wonder how to determine whether the indentation sounds should be on, i.e. in NVDA they really shouldn't, unless the implementation is better. However, I really dig the implementation in NVDA, where I can benefit a lot from absolute pitch to hear how many tabs/spaces are at the start of the line. |
|
@jvesouza makes sense. I think we should use probably use the same sound as for errors. Having two distinct sounds might be confusing. I have updated the first comment. |
|
Well, what if a user doesn’t have absolute pitch? I think panning the sound would be nice, to show it more spatially. Then again, if one is using their computer through speakers, that may not be as useful.
Devin Prater
***@***.***
Https://devinprater.flounder.online
… On Jan 27, 2022, at 7:14 AM, Leonard de Ruijter ***@***.***> wrote:
@devinprater <https://github.com/devinprater> While I'd love your suggestion, I wonder how to determine whether the indentation sounds should be on, i.e. in NVDA they really shouldn't, unless the implementation is better. However, I really dig the implementation in NVDA, where I can benefit a lot from absolute pitch to hear how many tabs/spaces are at the start of the line.
—
Reply to this email directly, view it on GitHub <#141635 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUMTTWZXMKV4ZJI64SEPUTUYFALJANCNFSM5M5SKGQA>.
You are receiving this because you were mentioned.
|
|
I don't think the same sound should be used for warnings and errors. My day job is Java development and there are often times when I'm coding and want to temporarily ignore warnings but be notified of errors. An example is creating a local variable but not immediately using it. I know Ill use the variable in a few minutes but don't want to hear a warning sound every time I go over the line. |
|
Should we use this issue to track a request to have settings for individual sounds? I'm thinking that as we keep adding more sounds it will be more likely that users will want to disable them some or all of the time. I know I already want the ability to disable the sound for folded regions of code, if I've folded a long method to level three so I can see the if statements without the body's I don't need a sound to play every time I hit the if statement. |
in my opinion, the sounds should be similar to each other, but still with a slight difference |
|
Another case is terminal bell: #47711 |
|
Going to chime in. At work, I have the need to know when lines exceed a specific length, as well as other formatting, and this is important enough to me that I was blocked on using VScode for work and stuck on notepad++ becauase of an NVDA add-on that could do what I needed. I ended up paying a friend who does a ton of VSCode extension stuff to write this to solve that problem. It's kind of a hack and prototypey, but works really well if you don't mind the webview abuse we went through to get it working. We went through a number of iterations and I'd say the sound design is pretty good, and iirc they're from freesound under cc0 or something like that so if you wanted you could probably just use the same ones. it'd be great to see some/all of this move over, though, because it's not exactly the most efficient thing when you try to get audio from a VSCode extension. There's no real way to do that without hacks that we could find. We were going to eventually port the sound to a Rust subprocess, but maybe that's unnecessary because it sounds like VSCode itself is going to be catching up. The ability to arrow through the line and have error/warning sounds when your cursor enters the actual error/warning is somewhat useful, so is getting feedback as you type. I'd consider doing those as well, but it's definitely the lowest priority thing. CC @wiresong so that they have visibility wr.t. if they get back around to this and start doing a bunch of stuff that we don't need to do. I'll provide actual feedback later. Only just updated, and didn't even know this was on the roadmap. Trying to get it on the roadmap is something we kept saying we'd do one of these days. |
|
@ahicks92 thanks a lot for the feedback. I was not aware of that extension - cool stuff! |
|
Yeah. He never really promoted it. Formatting is one of those weird problems where everyone hates it but no one considers this a solution: give it to users and they want it, but until you do they don't realize it could become a thing. Eventually I got work to do a bunch of ugly things with clang-format and some bash post-processing, but before that I was dealing with about a year and a half of manually formatting C to the BSD style because apparently no one supports that fully (or at least, not for our case). I'll make a point of getting back w.r.t. feedback in the next week or two. My bandwidth is at zero at the moment, didn't have a chance. before the above add-on (and as a "there is a need" datapoint) I was using this which is a lesser version of Sonica that only does "this line is too long" (the other features aren't audio). |
|
There are now these new audio cues:
Waiting for more sounds. |
|
Why did the folding sound change in 1.65? I was a fan of the old one and I find the new one barely audible. |
|
Warnings should really be different than errors. Referring to the UX and not making a statement on priorities, errors must be fixed now, but warnings can be left, and are even sometimes false positives. I also like the shorter sounds that Sonica went with. Not those specific sounds, just the general concept. It feels "snappier" for lack of a better way to put it, though we kind of got the warning/error sound design wrong by making the warning sound "scarier" than the error one (this is what happens when it's a weekend project and "we can't even play audio because..." hacks are the first concern). My screen reader is something like 5 times faster than the sound...not in terms of like latency, just this sort of ephemeral quality I don't know that I could explain well to someone sighted. I guess something like "by the time it's done I'm way over there"? I have yet to trigger any sound but warning/error despite being on insiders. Do we need more sound designers? is that the blocker? Small chance I can find people. I'd love to see sounds rolled out across the ui as widely as possible frankly. And my feedback w.r.t. really needing at least rulers if I'm going to move off Sonica definitely still stands; there is literally no efficient non-audio replacement for that UX. |
|
agreed re: the error vs warning distinction, they arent the same thing and will be dealt with in different ways, so we should have different sounds for them to eliminate ambiguity. |
|
I linked to it above in the comment that mentioned it first as an inline markdown link. But here it is again: https://github.com/wiresong/sonica You'll want to tweak the settings some, and it's not going to do panning and such unless you've configured rulers. Just search settings for sonica. We never really finished it: @wiresong was doing it for me and got it as far as I needed for work and then ran out of time, and I never had time for it to begin with or I'd not have paid someone plus it did what I needed to get off Notepad++. So it's rough around the edges. If it gets breaky alt-tab out and back in, and don't close the random webview editor because that's the audio-playing hack we came up with. |
See here for the discussion: #142016
Is this a bug? |
|
Also we use a different sound for warnings and a different one for errors. |
|
We added the sounds for inline completions and warnings. |
We have already introduced sounds for breakpoints, errors and folded regions. I think this went very well so we should consider to introduce more sounds for:
@gino-scarpino is working on the sound for 1.
The text was updated successfully, but these errors were encountered: