Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling (and rendering in general) is extremely slow #147253

Closed
zareami10 opened this issue Apr 11, 2022 · 6 comments
Closed

Scrolling (and rendering in general) is extremely slow #147253

zareami10 opened this issue Apr 11, 2022 · 6 comments
Assignees
Labels
info-needed Issue requires more information from poster notebook-perf

Comments

@zareami10
Copy link

zareami10 commented Apr 11, 2022

Ever since the release of the new jupyter version, the performance of the extension has dropped dramatically. Scrolling is laggy, rendering outputs eats the CPU and even the progress bar can be 10fps per second with any notebook larger than a couple of cells.

And this is not corner case issue, I have had this problem on many different machines and even different OSes.

In comparison jupyter on a browser is at least 20 times faster/smoother.

@zareami10 zareami10 added the bug Issue identified by VS Code Team member as probable bug label Apr 11, 2022
@DonJayamanne DonJayamanne removed their assignment Apr 11, 2022
@greazer greazer removed bug Issue identified by VS Code Team member as probable bug needs-triage labels Apr 11, 2022
@greazer greazer transferred this issue from microsoft/vscode-jupyter Apr 11, 2022
@rebornix
Copy link
Member

@zareami10 thanks for your feedback. It would be great if we can get more information to troubleshoot this issue. It seems there are multiple issues:

  • Scrolling is laggy. This is very likely due to the nature of virtualization.
  • rendering outputs eats the CPU and even the progress bar can be 10fps per second with any notebook larger than a couple of cells. This is interesting and currently I don't have any clue how is that happening. Would it be fine that when you run into the same issue again, share the notebook and a recording of what you are seeing with us?

@rebornix rebornix added the info-needed Issue requires more information from poster label Apr 11, 2022
@zareami10
Copy link
Author

zareami10 commented Apr 12, 2022

This is very likely due to the nature of virtualization.

I'm not really aware of the internals of the extension, can you please elaborate? Because it's bad enough to hinder working with any medium-sized notebooks, and I end up switching to the browser.

Would it be fine that when you run into the same issue again, share the notebook and a recording of what you are seeing with us?

Sure, but about the very high CPU-usage, I believe it mostly happens when there are outputs being shown/updated as the notebook runs.

@rchiodo rchiodo added important Issue identified as high-priority and removed notebook-triage labels Apr 18, 2022
@rebornix rebornix removed the important Issue identified as high-priority label Apr 19, 2022
@rebornix
Copy link
Member

@zareami10

I'm not really aware of the internals of the extension, can you please elaborate? Because it's bad enough to hinder working with any medium-sized notebooks, and I end up switching to the browser.

Do you mind running following commands to help collect logs for the slowness you are seeing?

  • Menu -> Help -> Toggle Developer Tools
  • Open Performance Page from the Developer Tools
  • Click the first round icon to start recording
  • Scrolling in the editor
  • Hit the round icon again to stop recording
  • Click the 5th icon to download the log and share with us

Sure, but about the very high CPU-usage, I believe it mostly happens when there are outputs being shown/updated as the notebook runs

Does the CPU go high when you are using the browser or it only happens with VS Code? Any pattern of the code you are running?

@zareami10
Copy link
Author

@zareami10

I'm not really aware of the internals of the extension, can you please elaborate? Because it's bad enough to hinder working with any medium-sized notebooks, and I end up switching to the browser.

Do you mind running following commands to help collect logs for the slowness you are seeing?

* Menu -> Help -> Toggle Developer Tools

* Open Performance Page from the Developer Tools

* Click the first round icon to start recording

* Scrolling in the editor

* Hit the round icon again to stop recording

* Click the 5th icon to download the log and share with us

Sure, but about the very high CPU
-usage, I believe it mostly happens when there are outputs being shown/updated as the notebook runs

Does the CPU go high when you are using the browser or it only happens with VS Code? Any pattern of the code you are running?

@rebornix

I have attached a profile on a kinda low-end hardware. But the situation is the same on stronger machines. Will profile on another machine with a dGPU too.

Profile-20220423T212859.json.zip

@zareami10
Copy link
Author

This is the other profilng:

Profile-20220423T223925.zip

Also no it only happens in Code. And my notebooks aren't really anything specific.

@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster notebook-perf
Projects
None yet
Development

No branches or pull requests

8 participants
@rebornix @DonJayamanne @greazer @rchiodo @zareami10 @vscodenpa and others