Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview CSS: data-vscode-theme-name attribute changes when the language changes #149661

Closed
pwang347 opened this issue May 16, 2022 · 1 comment · Fixed by #154635
Closed

Webview CSS: data-vscode-theme-name attribute changes when the language changes #149661

pwang347 opened this issue May 16, 2022 · 1 comment · Fixed by #154635
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Milestone
September 2022

Comments

@pwang347
Copy link
Member

pwang347 commented May 16, 2022 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.68.0-insider
  • OS Version: Windows 10

Steps to Reproduce:

  1. Write webview CSS depending on data-vscode-theme-name, e.g. see support limit markdown.styles active in single theme #97663 (comment)
  2. Change the language by installing a language pack - the CSS will stop working

Would it be possible to use an ID instead of a name string for this attribute (e.g. a new attribute to prevent breaking changes), or perhaps to force this attribute to be English only?
@mjbvz mjbvz self-assigned this May 16, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities webview Webview issues labels May 16, 2022
pingren added a commit to pingren/vscode that referenced this issue Jul 9, 2022
@pingren
Expose themeId in webviews
b9d499c 
Fixes microsoft#149661

Adds a data attribute to webviews with the themeId. Extension could write theme specific CSS for webviews. Unlike theme name, themeId will not change if changing the display language.
@pingren pingren mentioned this issue Jul 9, 2022
Merged
@pingren
Copy link
Contributor

pingren commented Jul 9, 2022

@pwang347 @mjbvz

I submitted a PR to address the issue. Please take a look when you have a moment.

pingren added a commit to pingren/vscode that referenced this issue Jul 24, 2022
@pingren
Expose data-vscode-theme-id and data-vscode-theme-label in webviews, …
b7560ee 
…deprecate data-vscode-theme-name.

Fixes microsoft#149661
pingren added a commit to pingren/vscode that referenced this issue Sep 5, 2022
@pingren
Expose data-vscode-theme-id and data-vscode-theme-label in webviews, …
7ab7b48 
…deprecate data-vscode-theme-name.

Fixes microsoft#149661
pingren added a commit to pingren/vscode that referenced this issue Sep 13, 2022
@pingren
Expose data-vscode-theme-id and data-vscode-theme-label in webviews, …
29fbfb5 
…deprecate data-vscode-theme-name.

Fixes microsoft#149661
@mjbvz mjbvz added this to the September 2022 milestone Sep 22, 2022
mjbvz added a commit that referenced this issue Sep 23, 2022
@pingren @mjbvz
Expose data-vscode-theme-id attribute in webviews, fix #149661 (#154635)
e42b88d 
* Expose data-vscode-theme-id and data-vscode-theme-label in webviews, deprecate data-vscode-theme-name.

Fixes #149661

* fix: remove useless id in test

* Use settingId and remove theme-label

Co-authored-by: Matt Bierner <matb@microsoft.com>
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 23, 2022
@connor4312 connor4312 added the verified Verification succeeded label Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

Expose data-vscode-theme-id attribute in webviews, fix #149661 pingren/vscode
5 participants
@connor4312 @pingren @pwang347 @mjbvz @vscodenpa