Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizing the notebook apis #149861

Closed
8 of 9 tasks
mjbvz opened this issue May 18, 2022 · 1 comment
Closed
8 of 9 tasks

Finalizing the notebook apis #149861

mjbvz opened this issue May 18, 2022 · 1 comment
Assignees
Milestone

Comments

@mjbvz mjbvz added this to the May 2022 milestone May 18, 2022
@mjbvz mjbvz self-assigned this May 18, 2022
@mjbvz mjbvz modified the milestones: May 2022, June 2022 May 26, 2022
@mjbvz mjbvz modified the milestones: June 2022, July 2022 Jun 28, 2022
@mjbvz mjbvz modified the milestones: July 2022, August 2022 Jul 25, 2022
@mjbvz mjbvz modified the milestones: August 2022, September 2022 Aug 17, 2022
@mjbvz mjbvz modified the milestones: September 2022, October 2022 Sep 22, 2022
@mjbvz mjbvz modified the milestones: October 2022, November 2022 Oct 20, 2022
@mjbvz mjbvz modified the milestones: November 2022, December 2022 Nov 28, 2022
@mjbvz mjbvz added the feature-request Request for new features or functionality label Dec 5, 2022
@mjbvz
Copy link
Collaborator Author

mjbvz commented Dec 9, 2022

At this point, we've finalized or removed the core notebook APIs. This work has included finalizing proposals for editing and notebook editors, as well as removing all the main proposals that saddled us with significant technical debt

The remaining api proposals are as follows:

  • notebookCellExecutionState — This is an advanced API but it also needs more thought as the current proposal has known gaps. With the limited number of use cases we know of, we are not sure finalizing it is worth it.

  • notebookControllerAffinityHidden — New API. @IanMatthewHuff Can you please determine if this should be finalized?

  • notebookControllerKind — Finalize or remove the notebookControllerKind API Proposal #168535 Small. Unclear if others beside Jupyter need this. Will follow up in linked issue

  • notebookDeprecated — Removing the notebookDeprecated proposal  #146831. Minor seeming but kind of annoying to get right. We are tracking this in the linked issue

  • notebookKernelSource — New api. @rebornix can you please determine if this API should be finalized

  • notebookLiveShare — This will likely be a proposal forever. LiveShare's use case is pretty unique and we don't think other extensions should use this API. It would be nice if we could move LiveShare off of this proposal but we don't know how to do this. The proposal is also not adding much debt to our code

  • notebookMessaging — The proposal name is not accurate since most parts of notebook messaging have already been finalized. For the remaining parts, NotebookRendererScript may be replaced by Add static preloads notebook contribution  #163511. It's not clear if notebook controller messaging is needed at all

  • notebookMime — NotebookCellData.mime #126280. Will follow up in linked issue

As I believe the original goal of this issue has largely been achieved, I'm going to close this issue. I will following up on the linked issues

@mjbvz mjbvz closed this as completed Dec 9, 2022
@mjbvz mjbvz removed the feature-request Request for new features or functionality label Jan 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants