Terminal smoke test failure

[alexr00]

  1) VSCode Smoke Tests (Web)
       Terminal
         Terminal Persistence
           detach/attach
             should persist buffer content:
     Error: Timeout: get terminal buffer '#terminal .terminal-wrapper' after 20 seconds.
      at Code.poll (/__w/1/s/test/automation/src/code.ts:256:11)
      at Code.waitForTerminalBuffer (/__w/1/s/test/automation/src/code.ts:225:3)
      at Terminal.waitForTerminalText (/__w/1/s/test/automation/src/terminal.ts:270:4)
      at Context.<anonymous> (src/areas/terminal/terminal-persistence.test.ts:78:5)

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=179605&view=logs&j=e5bbec05-0f06-558d-ebe9-5973d52063d2&t=a671546b-2469-5fb1-b2c9-08e628dcad6d

[meganrogge]

Also skipped the terminal profile tests bc they were failing and holding up PRs #156906

[meganrogge]

in this particular run, the quickpick is opened and nothing is typed

[meganrogge]

so it appears that this step didn't work according to the trace viewer, since no input happens

vscode/test/automation/src/quickaccess.ts

Lines 166 to 170 in 93e7d91

	// Type value if any
	if (value) {
	await this.quickInput.type(value);
	}

not sure why it didn't report a failure for

vscode/test/automation/src/code.ts

Lines 218 to 221 in 93e7d91

	async waitForSetValue(selector: string, value: string): Promise<void> {
	await this.poll(() => this.driver.setValue(selector, value), () => true, `set value '${selector}'`);
	}

[meganrogge]

never mind - ignore the above - the snapshots aren't available for most of the important part but going through the actions shows a terminal does get created

[meganrogge]

I investigated this and based on the actions log, this should be passing