Do not attempt to save unchanged file in diff-view when file is read only

[hansu]

I discovered almost exactly the same issue as #121539 on a windows machine.

1. file_a.txt is read-only and file_b.txt is writable
2. diff these files
3. make changes to file_b.txt
4. save changes in diff-editor
   Result: file_b.txt is saved and file_a.txt gets marked as changed and fails to save:
   

[bpasero]

We always target all sides of an editor when saving and when a save fails we automatically mark the editor as dirty to have a backup of the contents.

I agree the outcome here is not 100% ideal, but I think it is a corner case I would tolerate.

Anyway, treating as feature for changing this because the current behaviour actually is as intended.

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!