Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry API #160902

Merged
merged 14 commits into from
Oct 11, 2022
Merged

Telemetry API #160902

merged 14 commits into from
Oct 11, 2022

Conversation

lramos15
Copy link
Member

Initial implementation draft of #160090

This doesn't have any RPC communication back to the main process meaning extension telemetry is unable to congest the core VS code product.

@lramos15 lramos15 self-assigned this Sep 14, 2022
@lramos15 lramos15 removed the request for review from jrieken October 11, 2022 15:02
@lramos15 lramos15 marked this pull request as ready for review October 11, 2022 15:27
}
}

get apiTelemetryLogger(): vscode.TelemetryLogger {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the Lazy helper here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with the lazy helper, what exactly does that do here?

Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@lramos15 lramos15 merged commit e814cb5 into main Oct 11, 2022
@lramos15 lramos15 deleted the lramos15/telemetryAPI branch October 11, 2022 19:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants