Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel can have lots of ... #162006

Closed
mjbvz opened this issue Sep 27, 2022 · 8 comments
Closed

Panel can have lots of ... #162006

mjbvz opened this issue Sep 27, 2022 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 27, 2022

Testing #161802

  1. Open a panel view
  2. Hide the views specific to that panel
  3. Then hide the panel controls (such as close panel)

Bug

There are now two ... items next to each other in the panel header:

Screen Shot 2022-09-27 at 8 59 31 AM

These two have very similar names when you hover over them so it's difficult to tell which one is which :

Screen Shot 2022-09-27 at 9 00 11 AM

Screen Shot 2022-09-27 at 9 00 15 AM

@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 27, 2022

Would be helped by #147903

However I think we should also have clearer names when you hover over the ...

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2022

Also:

image

Could we consolidate them in a single menu with a separator?

cc @sbatten @daviddossett

@jrieken
Copy link
Member

jrieken commented Sep 28, 2022

Yeah, I believe the underlying issue is that two toolbars are being used here.

@jrieken jrieken added this to the September 2022 milestone Sep 28, 2022
@sandy081
Copy link
Member

Actions are nicely overflowing into ... sub menu when hidden in the side bar. I cannot reproduce it in the panel though. In views world, ViewContainerTitleContext and ViewTitleContext menus are used for secondary actions. I do not know how the hidden actions are moved into secondary actions, @jrieken Can you use these menus when hiding the primary actions? Is there something I have to adopt for this to happen?

@jrieken
Copy link
Member

jrieken commented Sep 28, 2022

Yeah, sorry I was confused. This is just one toolbar widget but it seems that there are simply two ... entries. I see the same and I don't believe this is related to hiding but to how views and view container commands are getting merged

Screenshot 2022-09-28 at 17 24 05

@jrieken jrieken modified the milestone: September 2022 Sep 28, 2022
@jrieken
Copy link
Member

jrieken commented Sep 28, 2022

Let's keep as stretch for September but this isn't a real new issue

@jrieken
Copy link
Member

jrieken commented Sep 29, 2022

Yeah, sorry I was confused.

I was really confused. So, for the bottom panel there are two toolbars are simply rendered next to each other... I think it's worth merging them into one.

Screenshot 2022-09-29 at 14 09 57

@sandy081 for now I think it's best to disable hiding for the global actions menu but we might want to revisit this later. Also, for the GHPR extension there is something off

@jrieken
Copy link
Member

jrieken commented Sep 29, 2022

For panels I have pushed a fixed and I have extracted #162006 (comment) into a separate issue because it seems unrelated to hiding menus and panels.

@jrieken jrieken closed this as completed Sep 29, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Sep 29, 2022
@roblourens roblourens added the verified Verification succeeded label Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants