Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notebook/cell/executePrimary contribution point #164505

Closed
mjbvz opened this issue Oct 24, 2022 · 0 comments · Fixed by #165532
Closed

Remove notebook/cell/executePrimary contribution point #164505

mjbvz opened this issue Oct 24, 2022 · 0 comments · Fixed by #165532
Assignees
@roblourens
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
November 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 24, 2022

Tracks removing the notebook/cell/executePrimary contribution point. This contribution point is the only remaining user of the notebookEditor api proposal
@mjbvz mjbvz added the debt Code quality issues label Oct 24, 2022
@mjbvz mjbvz added this to the November 2022 milestone Oct 24, 2022
@roblourens roblourens mentioned this issue Nov 4, 2022
Merged
roblourens added a commit that referenced this issue Nov 4, 2022
@roblourens
Remove executePrimary and notebookEditor proposal
0be2241 
Fix #164505
roblourens added a commit that referenced this issue Nov 4, 2022
@roblourens
Remove executePrimary and notebookEditor proposal (#165532)
285c607 
Fix #164505
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Remove executePrimary and notebookEditor proposal microsoft/vscode
3 participants
@roblourens @mjbvz @vscodenpa