Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Modified elsewhere setting indicator accessibility #167088

Closed
3 tasks done
rzhao271 opened this issue Nov 23, 2022 · 0 comments
Closed
3 tasks done

Test: Modified elsewhere setting indicator accessibility #167088

rzhao271 opened this issue Nov 23, 2022 · 0 comments

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Nov 23, 2022

Refs: #159088

Complexity: 3

Create Issue


In the Settings editor, there are indicators, which are labels that show up in parentheses next to some settings such as "Modified elsewhere".

For the following steps, make sure to test both the case where the indicator says "Modified elsewhere", and where the indicator starts with "Modified in".

  1. Open the Settings editor. Clear the search query if there is one.
  2. Navigate to a "Modified elsewhere" indicator. editor.tabSize should have one, and another easy way to make that indicator appear is to modify a setting in the workspace only, and then to navigate back to the User scope.
  3. If the indicator says "Modified in: $scopeName", then focus should only go to the $scopeName part of the indicator, which is a link. Otherwise, the entire indicator should be outlined.
  4. Once focused on an indicator, press space or enter to open the hover and focus it.
  5. Alternatively, one should be able to hover over an indicator with a mouse, and then click on the hover to focus it.
  6. For the Modified elsewhere indicator hover, tab and shift+tab should tab around within the hover contents only. The hover in this case acts as a focus trap, where focus is contained inside the hover until the hover is closed.
  7. Pressing escape or another non-tab key should close the hover. Clicking elsewhere should also close the hover.
  8. Pressing enter or space on a link inside the hover should act the same as clicking on it.
  9. The indicator and hover should be navigable with a screenreader.
@vscodenpa vscodenpa added this to the November 2022 milestone Nov 23, 2022
@weinand weinand removed their assignment Nov 29, 2022
@amunger amunger removed their assignment Nov 29, 2022
@paulacamargo25 paulacamargo25 removed their assignment Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants