Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File with space in name not linkified in Python error output #172242

Closed
joyceerhl opened this issue Jan 24, 2023 · 1 comment · Fixed by #172259
Closed

File with space in name not linkified in Python error output #172242

joyceerhl opened this issue Jan 24, 2023 · 1 comment · Fixed by #172259
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Milestone
January 2023

Comments

@joyceerhl
Copy link
Contributor

Testing #172084

The first link output below is good, the second link stops at the space:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-links labels Jan 24, 2023
@Tyriar Tyriar added this to the January 2023 milestone Jan 24, 2023
@Tyriar
Copy link
Member

Tyriar commented Jan 24, 2023

We can just exclude leading and trailing whitespace 👍

Tyriar added a commit that referenced this issue Jan 24, 2023
@Tyriar
Exclude leading and trailing whitespace in path check
149601b 
Fixes #172242
@Tyriar Tyriar mentioned this issue Jan 24, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 24, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Jan 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Exclude leading and trailing whitespace in path check microsoft/vscode
3 participants
@Tyriar @joyceerhl @vscodenpa