Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal follow link hover only shows up when I press cmd #172366

Closed
isidorn opened this issue Jan 25, 2023 · 5 comments
Closed

Terminal follow link hover only shows up when I press cmd #172366

isidorn opened this issue Jan 25, 2023 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmation-pending terminal-links verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2023

Testing #172084

Hover over the link -> no UI decoration in the terminal.
Only the hover shows when I am holding Cmd.

I am worried that this is undiscoverable, as the only way to figure out that I have to press cmd requires me to already press cmd.
Can we just show this hover on every link hover (not requiring cmd is pressed)

Screenshot 2023-01-25 at 10 46 52

@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2023

@isidorn if you need to hold cmd it means it's a fallback "word" link: https://code.visualstudio.com/docs/terminal/basics#_links, ie. the URI was not detected properly. Were you on insiders (not exploration?) here?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jan 25, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Jan 25, 2023

I was on VS Code Insiders. Should I have used exploration? Did not catch that.

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2023

vscode-insiders will only work on Insiders is what I meant. This should be working, it could be related to the uri format?

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug confirmation-pending terminal-links and removed info-needed Issue requires more information from poster labels Jan 26, 2023
@Tyriar Tyriar added this to the Backlog milestone Jan 26, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Jan 27, 2023

Here's the command I run
And this path actually exists (clicking on it opens that folder)

echo "vscode-insiders://file/Users/isidor/development/w"

@Tyriar
Copy link
Member

Tyriar commented Dec 8, 2023

Seems to be working for me

image

@Tyriar Tyriar closed this as completed Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
@isidorn isidorn added the verified Verification succeeded label May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmation-pending terminal-links verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants