Build task not found sometimes

[rebornix]

• Install Java extension pack
• Open VS Code repo
• Cmd+Shift+B
• 🐛 Java extension prompts error and the task detection never finishes

[meganrogge]

We have to wait for extensions to be registered before reading the tasks because of task contributions from extensions. I don't think we can change this. @alexr00 thoughts?

[alexr00]

We could have a timeout per task provider. If a task provider doesn't provide tasks for 3 minutes after we ask for tasks then it's likely it will never provide tasks. That would let us show the tasks for all the other extensions except the slow one.

[joyceerhl]

I just hit this again #176536, #173184 in a VS Code instance that had been running for quite some time. Are there logs that we can provide next time this happens? I enabled trace logging and looked in the Tasks output channel but did not see anything other than a warning about shell tasks being unavailable.

[meganrogge]

I will try to get to this in March, no logs are needed as we understand how this could happen

[meganrogge]

Original repro steps still work 👍🏼

[meganrogge]

Steps still work sometimes - saw this when I reproduced

[meganrogge]

Apparently this still happens

[meganrogge]

ok in OSS where I'm reproducing, it goes in here like I thought

then there are no workspace tasks found

so it goes here

[meganrogge]

only the ContributedTasks are used here

[meganrogge]

so the issue is the ConfiguredTasks aren't resolved in this case. it's not timing dependent - I can repro long after the window has opened.

[meganrogge]

I think contributed here should have a size > 0

[meganrogge]

interesting - I wonder if this is the issue

[meganrogge]

worked:

failed:

[meganrogge]

so I think what's happening is if I trigger the build task before folder open, the promise is set but the tasks for that folder aren't parsed. then we return that promise indefinitely.

I think checking if the runSource is folderOpen is in order here and in that case, we want to update the workspace tasks instead of returning the promise

[meganrogge]

yep - I believe that works.

So the repro is to run the build task before the folder opens.

[meganrogge]

Just reproduced twice. When I did, both times it said this:

Warning: npm tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: gulp tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: npm tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: process tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

Workspace folder was undefined
Workspace folder was undefined

[meganrogge]

still happens in the build I created with the latest fix. note that i don't see extensions getting activated in the status bar here at all 🤔

I also don't see the workspace folder undefined message anymore, but still see that the tasks are unavailable in the current environment.

build.mov

[meganrogge]

the moment I change the tasks.json file, it starts to work. IE when this is called

return this._updateWorkspaceTasks(TaskRunSource.ConfigurationChange);

[meganrogge]

While it's possible (extremely rare) that a user will still hit this if they run the build task before a particular execution context has been set, this fix will prevent that from reproducing.

To verify, open VS code (typically a restart) and run the build task. If you do see the quickpick instead of the default build task getting, run, then the next time you run the build task, you should not see it.

The above should be hard to reproduce though - and only possible if you time it just right. Before, this would happen more frequently and was reproducible until window reload.