Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlay hint padding not rendered on the right side #173431

Closed
NoahELE opened this issue Feb 4, 2023 · 3 comments
Closed

Inlay hint padding not rendered on the right side #173431

NoahELE opened this issue Feb 4, 2023 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug inlay-hints insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@NoahELE
Copy link

NoahELE commented Feb 4, 2023

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.75.0
  • OS Version: win 11

Steps to Reproduce:

  1. rust-analyzer inlay hints' padding look weird.
{
  "editor.inlayHints.enabled": "on",
  "editor.inlayHints.padding": true,
}

The inlay type hint for String has no round padding on right side, while the i32 type hint looks normal.

image

@NoahELE
Copy link
Author

NoahELE commented Feb 4, 2023

I think it might have something to do with String type hint being ctrl-clickable. The non-clickable types like i32 is fine. Also, for other languages that does not support ctrl-click on inlay hints, the rendering is also fine.

@NoahELE

This comment was marked as spam.

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2023
@jrieken
Copy link
Member

jrieken commented Dec 4, 2023

I can reproduce, but only with Rust Analyzer. This issue is that it returns a label part that's empty. When rending we add the padding/border to that element but because its empty, it never gets rendered

Screenshot 2023-12-04 at 12 54 56

@jrieken jrieken added this to the December 2023 milestone Dec 4, 2023
jrieken added a commit that referenced this issue Dec 4, 2023
@jrieken jrieken closed this as completed in 5693458 Dec 4, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
@dbaeumer dbaeumer added the verified Verification succeeded label Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug inlay-hints insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants