Skip to content

ctx keys improvements #176502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2023
Merged

ctx keys improvements #176502

merged 3 commits into from
Mar 8, 2023

Conversation

ulugbekna
Copy link
Contributor

  • context keys: parser: don't pass g/y regex flags with =~ operator
  • context keys: parser: reuse the same parse error object
  • context keys: export some classes for testing purposes

@ulugbekna ulugbekna self-assigned this Mar 8, 2023
@vscodenpa vscodenpa added this to the March 2023 milestone Mar 8, 2023
@ulugbekna ulugbekna merged commit 3b8ff0c into main Mar 8, 2023
@ulugbekna ulugbekna deleted the ulugbekna/ctx-keys-reset-regex-lastIndex branch March 8, 2023 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandy081 sandy081 sandy081 approved these changes

Assignees

@ulugbekna ulugbekna

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@ulugbekna @sandy081 @vscodenpa