InlineCompletionContext.triggerKind is always Automatic

[hstaudacher]

Does this issue occur when all extensions are disabled?: Yes

Version: 1.78.0-insider
Commit: b19017c
Date: 2023-04-21T05:39:53.263Z
Electron: 22.4.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: Yes

Steps to Reproduce:

1. Execute the command editor.action.inlineSuggest.trigger
2. In the InlineCompletionItemProvider implementation provideInlineCompletionItems method you have access to the InlineCompletionContext which has a triggerkind. The 2 possibilities here are Automatic and Invoke. The value here is always Automatic regardless of auto invoke or executing the command.

In Copliot

This issue prevents the Copilot extension from distinguishing the triggers. Our users ask for a way to disable auto completions while still allowing manual triggers. It seems the triggerkind is the correct way to determine this trigger but it doe snot work.

[SmallLemur]

@isidorn do you know if it is something that can be prioritised ? it is blocking one of our large customer

[isidorn]

@hstaudacher thanks for opening this issue. Can you share the user feedback? This feels like a UI interaction, and maybe we should have a setting on the VS Code side for this, and not on the Copilot side. Maybe once we finally tackle #131940 this interaction for your customers will also be improved.

@SmallLemur thanks for the ping, I can comment more once @hediet analysis this issue.

[hstaudacher]

Sure, here are 2 examples:

• https://github.com/orgs/community/discussions/46437
• https://github.com/orgs/community/discussions/9817

Having a VSCode solution sounds fine at first. Thinking about it I wonder how to name it. I mean, our customers do not know anything about an InlineCompletionProvider or so. They know Copilot, so they are looking for Copilot settings.

I think it would really help us if the existing API would just work. We also have a setting to completely disable inline completions already.

[isidorn]

Thanks for sharing - this is great.
https://github.com/orgs/community/discussions/46437 feels unrelated to this, these folk have a problem of having multiple inline suggestion providers. Something we plan to tackle better on the VS Code side.

https://github.com/orgs/community/discussions/9817 sounds like a valid use case, and imho should be VS Code driven. Good point for having "Copilot" mentioned in the setting name for ease of finding. Can we first, better understand why users find Inline Suggestions annoying in this case. For example, is it because they are getting in the way of the Suggest Widget or it is completely unrelated. @SmallLemur could you find this out?

Let's see what @hediet thinks.

[SmallLemur]

From what I gathered, it is not not entirely related to the suggest widget but also preferences of the team using it. In the case of our customer, they simply prefer to have control on when they get a suggestion. So this enhancement is just to provide a way to our user to have only manual suggestion if they wish to.

[mroch]

this is a regression. editor.action.inlineSuggest.trigger results in "Invoked" in 1.77.3, and "Automatic" in 1.78.0-insider (b19017c)

[hstaudacher]

Thx for the fast fix! You guys rock 🚀

[SmallLemur]

Thank you for the super fast turn around

[isidorn]

@hstaudacher can you please verify on your side if this indeed fixes the issue? This is included in the latest VS Code Insiders. Thanks!

[hstaudacher]

I can confirm that the trigger does also have the value Invoke now. Unfortunately manually triggered completions are not showing up at all now 😞 . This still works in 1.77 but not in the latest insiders.

I'm using:

Version: 1.78.0-insider
Commit: 2902f278ad8e2d830fa6883d3d8fd7b5c2ca59e9
Date: 2023-04-25T05:59:25.219Z
Electron: 22.4.8
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: Yes

[isidorn]

@hstaudacher thanks for letting us know.
@hediet I can reproduce, and I opened a new issue #180792